From: David Miller <davem@davemloft.net>
To: kaber@trash.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH]: net: ipv6: fix oops in inet_putpeer()
Date: Mon, 20 Aug 2012 02:58:22 -0700 (PDT) [thread overview]
Message-ID: <20120820.025822.875182755255293091.davem@davemloft.net> (raw)
In-Reply-To: <Pine.GSO.4.63.1208181729020.7404@stinky-local.trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Sat, 18 Aug 2012 17:32:31 +0200 (MEST)
> The attached patch fixes an oops in inet_putpeer(). Please see the
> changelog entry for details.
>
> An alternative fix would be to check whether rt6_peer_ptr() returns
> NULL before invoking inet_putpeer(), but properly initializing the
> peer looks cleaner to me.
This is fine for now, applied, thanks Patrick.
There was a built-in assumption that xfrm_fill_dst() would run to
completion before we'd try to release these things, because there in
xfrm6_policy.c's xfrm6_fill_dst, we'd do the rt6_transfer_peer().
But that's obviously not the case if errors happen meanwhile.
prev parent reply other threads:[~2012-08-20 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 15:32 [PATCH]: net: ipv6: fix oops in inet_putpeer() Patrick McHardy
2012-08-20 9:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120820.025822.875182755255293091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).