From: David Miller <davem@davemloft.net>
To: christoph.paasch@uclouvain.be
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] ipv4: Use newinet->inet_opt in inet_csk_route_child_sock()
Date: Tue, 21 Aug 2012 14:49:47 -0700 (PDT) [thread overview]
Message-ID: <20120821.144947.2102823805754391660.davem@davemloft.net> (raw)
In-Reply-To: <1345467129-4540-1-git-send-email-christoph.paasch@uclouvain.be>
From: Christoph Paasch <christoph.paasch@uclouvain.be>
Date: Mon, 20 Aug 2012 14:52:09 +0200
> Since 0e734419923bd ("ipv4: Use inet_csk_route_child_sock() in DCCP and
> TCP."), inet_csk_route_child_sock() is called instead of
> inet_csk_route_req().
>
> However, after creating the child-sock in tcp/dccp_v4_syn_recv_sock(),
> ireq->opt is set to NULL, before calling inet_csk_route_child_sock().
> Thus, inside inet_csk_route_child_sock() opt is always NULL and the
> SRR-options are not respected anymore.
> Packets sent by the server won't have the correct destination-IP.
>
> This patch fixes it by accessing newinet->inet_opt instead of ireq->opt
> inside inet_csk_route_child_sock().
>
> Reported-by: Luca Boccassi <luca.boccassi@gmail.com>
> Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Applied, thanks.
prev parent reply other threads:[~2012-08-21 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 12:52 [PATCH v2] ipv4: Use newinet->inet_opt in inet_csk_route_child_sock() Christoph Paasch
2012-08-21 21:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821.144947.2102823805754391660.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christoph.paasch@uclouvain.be \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).