From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
casteyde.christian@free.fr
Subject: Re: [PATCH] ipv4: fix ip header ident selection in __ip_make_skb()
Date: Tue, 21 Aug 2012 14:51:27 -0700 (PDT) [thread overview]
Message-ID: <20120821.145127.2073110448958014270.davem@davemloft.net> (raw)
In-Reply-To: <1345483605.5158.345.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 20 Aug 2012 19:26:45 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> Christian Casteyde reported a kmemcheck 32-bit read from uninitialized
> memory in __ip_select_ident().
>
> It turns out that __ip_make_skb() called ip_select_ident() before
> properly initializing iph->daddr.
>
> This is a bug uncovered by commit 1d861aa4b3fb (inet: Minimize use of
> cached route inetpeer.)
>
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=46131
>
> Reported-by: Christian Casteyde <casteyde.christian@free.fr>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Stephen Hemminger <shemminger@vyatta.com>
Applied, thanks Eric.
prev parent reply other threads:[~2012-08-21 21:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 17:26 [PATCH] ipv4: fix ip header ident selection in __ip_make_skb() Eric Dumazet
2012-08-21 21:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120821.145127.2073110448958014270.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=casteyde.christian@free.fr \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).