* [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID
@ 2012-08-22 10:26 Giuseppe CAVALLARO
2012-08-22 10:26 ` [PATCH (net.git) 2/2] stmmac: fix a typo in the macro used to mask the mmc irq Giuseppe CAVALLARO
2012-08-23 2:14 ` [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Giuseppe CAVALLARO @ 2012-08-22 10:26 UTC (permalink / raw)
To: netdev; +Cc: Giuseppe Cavallaro, Gianni Antoniazzi
Erroneously the DWMAC_CORE_3_40 was set to 34 instead of 0x34.
This can generate problems when run on old chips because
the driver assumes that there are the extra 16 regs available
for perfect filtering.
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Gianni Antoniazzi <gianni.antoniazzi-ext@st.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
index f90fcb5..b4c44a5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
@@ -229,6 +229,6 @@ enum rtc_control {
#define GMAC_MMC_RX_CSUM_OFFLOAD 0x208
/* Synopsys Core versions */
-#define DWMAC_CORE_3_40 34
+#define DWMAC_CORE_3_40 0x34
extern const struct stmmac_dma_ops dwmac1000_dma_ops;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH (net.git) 2/2] stmmac: fix a typo in the macro used to mask the mmc irq
2012-08-22 10:26 [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID Giuseppe CAVALLARO
@ 2012-08-22 10:26 ` Giuseppe CAVALLARO
2012-08-23 2:14 ` David Miller
2012-08-23 2:14 ` [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Giuseppe CAVALLARO @ 2012-08-22 10:26 UTC (permalink / raw)
To: netdev; +Cc: Giuseppe Cavallaro
This patch fixes the name of the macro used to mask the
mmc interrupt: erroneously it was used: MMC_DEFAUL_MASK.
Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
---
drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
index c07cfe9..0c74a70 100644
--- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
@@ -33,7 +33,7 @@
#define MMC_TX_INTR 0x00000108 /* MMC TX Interrupt */
#define MMC_RX_INTR_MASK 0x0000010c /* MMC Interrupt Mask */
#define MMC_TX_INTR_MASK 0x00000110 /* MMC Interrupt Mask */
-#define MMC_DEFAUL_MASK 0xffffffff
+#define MMC_DEFAULT_MASK 0xffffffff
/* MMC TX counter registers */
@@ -147,8 +147,8 @@ void dwmac_mmc_ctrl(void __iomem *ioaddr, unsigned int mode)
/* To mask all all interrupts.*/
void dwmac_mmc_intr_all_mask(void __iomem *ioaddr)
{
- writel(MMC_DEFAUL_MASK, ioaddr + MMC_RX_INTR_MASK);
- writel(MMC_DEFAUL_MASK, ioaddr + MMC_TX_INTR_MASK);
+ writel(MMC_DEFAULT_MASK, ioaddr + MMC_RX_INTR_MASK);
+ writel(MMC_DEFAULT_MASK, ioaddr + MMC_TX_INTR_MASK);
}
/* This reads the MAC core counters (if actaully supported).
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID
2012-08-22 10:26 [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID Giuseppe CAVALLARO
2012-08-22 10:26 ` [PATCH (net.git) 2/2] stmmac: fix a typo in the macro used to mask the mmc irq Giuseppe CAVALLARO
@ 2012-08-23 2:14 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-08-23 2:14 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: netdev, gianni.antoniazzi-ext
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Wed, 22 Aug 2012 12:26:15 +0200
> Erroneously the DWMAC_CORE_3_40 was set to 34 instead of 0x34.
> This can generate problems when run on old chips because
> the driver assumes that there are the extra 16 regs available
> for perfect filtering.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Gianni Antoniazzi <gianni.antoniazzi-ext@st.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH (net.git) 2/2] stmmac: fix a typo in the macro used to mask the mmc irq
2012-08-22 10:26 ` [PATCH (net.git) 2/2] stmmac: fix a typo in the macro used to mask the mmc irq Giuseppe CAVALLARO
@ 2012-08-23 2:14 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-08-23 2:14 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: netdev
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Wed, 22 Aug 2012 12:26:16 +0200
> This patch fixes the name of the macro used to mask the
> mmc interrupt: erroneously it was used: MMC_DEFAUL_MASK.
>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-23 2:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 10:26 [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID Giuseppe CAVALLARO
2012-08-22 10:26 ` [PATCH (net.git) 2/2] stmmac: fix a typo in the macro used to mask the mmc irq Giuseppe CAVALLARO
2012-08-23 2:14 ` David Miller
2012-08-23 2:14 ` [PATCH (net.git) 1/2] stmmac: fix GMAC syn ID David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).