Re: [PATCH net-next] xfrm: fix RCU bugs

[David Miller <davem@davemloft.net>]

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 19 Aug 2012 12:31:48 +0200

> From: Eric Dumazet <edumazet@google.com>
> 
> This patch reverts commit 56892261ed1a (xfrm: Use rcu_dereference_bh to
> deference pointer protected by rcu_read_lock_bh), and fixes bugs
> introduced in commit 418a99ac6ad ( Replace rwlock on xfrm_policy_afinfo
> with rcu )
> 
> 1) We properly use RCU variant in this file, not a mix of RCU/RCU_BH
> 
> 2) We must defer some writes after the synchronize_rcu() call or a reader
>  can crash dereferencing NULL pointer.
> 
> 3) Now we use the xfrm_policy_afinfo_lock spinlock only from process
> context, we no longer need to block BH in xfrm_policy_register_afinfo()
> and xfrm_policy_unregister_afinfo()
> 
> 4) Can use RCU_INIT_POINTER() instead of rcu_assign_pointer() in
> xfrm_policy_unregister_afinfo()
> 
> 5) Remove a forward inline declaration (xfrm_policy_put_afinfo()),
>   and also move xfrm_policy_get_afinfo() declaration.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.