From: David Miller <davem@davemloft.net>
To: xiong@qca.qualcomm.com
Cc: cjren@qca.qualcomm.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, qca-linux-team@qualcomm.com,
nic-devel@qualcomm.com, rodrigue@qca.qualcomm.com
Subject: Re: [PATCH v2] net: add new QCA alx ethernet driver
Date: Wed, 22 Aug 2012 23:40:19 -0700 (PDT) [thread overview]
Message-ID: <20120822.234019.1546353507351890178.davem@davemloft.net> (raw)
In-Reply-To: <157393863283F442885425D2C45428562A4F5169@nasanexd02f.na.qualcomm.com>
From: "Huang, Xiong" <xiong@qca.qualcomm.com>
Date: Thu, 23 Aug 2012 06:35:40 +0000
>> This is why we require that portable, sane, interfaces are added to ethtool for
>> driver diagnostics. That way users can perform a task in the same way
>> regardless of what hardware and driver are underneath.
>
> I quite agree you on using ethtool to implement it. we did consider it.
> But ethtool has some limitation, for example, the NIC has built-in OTP (TWSI interface)
> And Flash (External SPI interface), their properties are quite different with EEPROM which
> Ethtool supports.
> To support such memory (OTP/Flash), we need additional input parameters.
Then add a new ethtool operation to support your use case, that's
exactly what I was telling you to do.
Did it really not occur to you that you perhaps you should extend
existing generic facilities to suit your needs instead of creating
private facilities that no other driver can use?
next prev parent reply other threads:[~2012-08-23 6:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 16:42 [PATCH v2] net: add new QCA alx ethernet driver cjren
2012-08-23 5:57 ` David Miller
2012-08-23 6:35 ` Huang, Xiong
2012-08-23 6:40 ` David Miller [this message]
2012-08-23 6:56 ` Huang, Xiong
2012-08-23 7:13 ` David Miller
2012-08-23 10:28 ` Luis R. Rodriguez
2012-08-23 21:09 ` Ben Hutchings
2012-08-24 1:55 ` Huang, Xiong
2012-08-24 2:09 ` Ben Hutchings
2012-08-24 2:39 ` Huang, Xiong
2012-08-24 4:32 ` Luis R. Rodriguez
2012-08-24 5:34 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120822.234019.1546353507351890178.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cjren@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic-devel@qualcomm.com \
--cc=qca-linux-team@qualcomm.com \
--cc=rodrigue@qca.qualcomm.com \
--cc=xiong@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).