* [PATCH net-next] packet: fix broken build.
@ 2012-08-23 12:55 Rami Rosen
2012-08-23 16:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rami Rosen @ 2012-08-23 12:55 UTC (permalink / raw)
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: xemul@parallels.com, edumazet@google.com
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
This patch fixes a broken build due to a missing header:
...
CC net/ipv4/proc.o
In file included from include/net/net_namespace.h:15,
from net/ipv4/proc.c:35:
include/net/netns/packet.h:11: error: field 'sklist_lock' has incomplete type
...
The lock of netns_packet has been replaced by a recent patch to be a mutex instead of a spinlock,
but we need to replace the header file to be linux/mutex.h instead of linux/spinlock.h as well.
See commit 0fa7fa98dbcc2789409ed24e885485e645803d7f:
packet: Protect packet sk list with mutex (v2) patch,
Signed-off-by: Rami Rosen <rosenr@marvell.com>
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 348 bytes --]
diff --git a/include/net/netns/packet.h b/include/net/netns/packet.h
index 4780b08..17ec2b9 100644
--- a/include/net/netns/packet.h
+++ b/include/net/netns/packet.h
@@ -5,7 +5,7 @@
#define __NETNS_PACKET_H__
#include <linux/rculist.h>
-#include <linux/spinlock.h>
+#include <linux/mutex.h>
struct netns_packet {
struct mutex sklist_lock;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] packet: fix broken build.
2012-08-23 12:55 [PATCH net-next] packet: fix broken build Rami Rosen
@ 2012-08-23 16:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-08-23 16:29 UTC (permalink / raw)
To: rosenr; +Cc: netdev, xemul, edumazet
From: Rami Rosen <rosenr@marvell.com>
Date: Thu, 23 Aug 2012 15:55:41 +0300
> This patch fixes a broken build due to a missing header:
> ...
> CC net/ipv4/proc.o
> In file included from include/net/net_namespace.h:15,
> from net/ipv4/proc.c:35:
> include/net/netns/packet.h:11: error: field 'sklist_lock' has incomplete type
> ...
>
> The lock of netns_packet has been replaced by a recent patch to be a mutex instead of a spinlock,
> but we need to replace the header file to be linux/mutex.h instead of linux/spinlock.h as well.
>
> See commit 0fa7fa98dbcc2789409ed24e885485e645803d7f:
> packet: Protect packet sk list with mutex (v2) patch,
>
> Signed-off-by: Rami Rosen <rosenr@marvell.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-23 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-23 12:55 [PATCH net-next] packet: fix broken build Rami Rosen
2012-08-23 16:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).