From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next 1/3] teamd: don't print warn message on -ESRCH during event send Date: Thu, 23 Aug 2012 15:31:53 +0200 Message-ID: <20120823133153.GB16103@minipsycho.orion> References: <1345728413-10298-1-git-send-email-jiri@resnulli.us> <1345728413-10298-2-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, brouer@redhat.com, ogerlitz@mellanox.com To: netdev@vger.kernel.org Return-path: Received: from mail-wg0-f42.google.com ([74.125.82.42]:48287 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933985Ab2HWNb6 (ORCPT ); Thu, 23 Aug 2012 09:31:58 -0400 Received: by wgbfm10 with SMTP id fm10so715704wgb.1 for ; Thu, 23 Aug 2012 06:31:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1345728413-10298-2-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: Oups. Subject should start with "team:" without "d" :( David, should I repost? Thu, Aug 23, 2012 at 03:26:51PM CEST, jiri@resnulli.us wrote: >When no one is listening on NL socket, -ESRCH is returned and warning >message is printed. This message is confusing people and in fact has no >meaning. So do not print it in this case. > >Reported-by: Or Gerlitz >Signed-off-by: Jiri Pirko >--- > drivers/net/team/team.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c >index 17ce11b..4010bcd 100644 >--- a/drivers/net/team/team.c >+++ b/drivers/net/team/team.c >@@ -2487,7 +2487,7 @@ static void __team_options_change_check(struct team *team) > list_add_tail(&opt_inst->tmp_list, &sel_opt_inst_list); > } > err = team_nl_send_event_options_get(team, &sel_opt_inst_list); >- if (err) >+ if (err && err != -ESRCH) > netdev_warn(team->dev, "Failed to send options change via netlink (err %d)\n", > err); > } >@@ -2518,9 +2518,9 @@ static void __team_port_change_check(struct team_port *port, bool linkup) > > send_event: > err = team_nl_send_event_port_list_get(port->team); >- if (err) >- netdev_warn(port->team->dev, "Failed to send port change of device %s via netlink\n", >- port->dev->name); >+ if (err && err != -ESRCH) >+ netdev_warn(port->team->dev, "Failed to send port change of device %s via netlink (err %d)\n", >+ port->dev->name, err); > > } > >-- >1.7.11.4 >