Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: netdev@vger.kernel.org, shemminger@vyatta.com,
	shchepetkov@ispras.ru, bjorn@mork.no, mike@marineau.org
Subject: Re: [PATCH net-next] net: Set device operstate at registration time
Date: Fri, 24 Aug 2012 12:48:15 -0400 (EDT)	[thread overview]
Message-ID: <20120824.124815.1292475998883382478.davem@davemloft.net> (raw)
In-Reply-To: <1345497411.2659.28.camel@bwh-desktop.uk.solarflarecom.com>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 20 Aug 2012 22:16:51 +0100

> This initialises the operstate synchronously at registration time
> only.

Ok, this looks good to me, applied.  Thanks Ben.

> This seems to deal properly with the registration-time problem, but not
> the case where a device is brought down and then up again.  Many but not
> all drivers that support carrier detection call netif_carrier_off() in
> their ndo_stop method.  Should the others be changed, or is there some
> way we can make that automatic?

There are several cases.

For example, if the device does not power down the PHY over stop/start
it should leave the carrier state alone.  This is the case for every
NIC that runs management firmware, which therefore needs the link to
stay up even when the NIC is administratively brought down.

If it does power down the PHY, that netif_carrier_off() call should
already be contained in the PHY powerdown code.

  reply	other threads:[~2012-08-24 16:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 21:16 [PATCH net-next] net: Set device operstate at registration time Ben Hutchings
2012-08-24 16:48 ` David Miller [this message]
2012-08-24 16:53   ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120824.124815.1292475998883382478.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=bjorn@mork.no \
    --cc=mike@marineau.org \
    --cc=netdev@vger.kernel.org \
    --cc=shchepetkov@ispras.ru \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox