Re: [PATCH net-next 0/15] qlcnic: patches for new adapter - Qlogic 83XX CNA

[David Miller <davem@davemloft.net>]

From: Sony Chacko <sony.chacko@qlogic.com>
Date: Thu, 23 Aug 2012 21:07:04 -0400

> From: Sony Chacko <sony.chacko@qlogic.com>
> 
> Patch series will restructure the existing 82XX adapter driver to create
> a common driver for Qlogic 82XX and 83XX adapters.
> 
> Please apply it to net-next.

Sorry, this is terrible.

Firstly, I'm not going to let you create arbitrary new sysfs and
debugfs crap for facilities that are already supported by the kernel
via other interfaces.

For example, providing a facility to read and write the PCI BARs
is completely pointless.  Use the PCI config space access APIs for
this if you want to do this from userspace.

The patches are also much more verbose than they need to be.  When you
move an operation to the new hwops, keep the existing function name
but make it an inline function that invokes the hwop.

That way you won't need hundreds of lines in your patch that look
like this:


-	qlcnic_clear_lb_mode(adapter);
+	ahw->hw_ops->clear_loopback(adapter, mode);

Instead you'd have:

static inline void qlcnic_clear_lb_mode(struct qlcnic_adapter *adapter, u8 mode)
{
	struct qlcnic_hardware_context *ahw = &adapter->ahw;

	ahw->hw_ops->clear_loopback(adapter, mode);
}