From: David Miller <davem@davemloft.net>
To: ncardwell@google.com
Cc: nanditad@google.com, ycheng@google.com, mattmathis@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net-tcp: fix cwnd reduction for non-sack recovery
Date: Fri, 24 Aug 2012 13:49:51 -0400 (EDT) [thread overview]
Message-ID: <20120824.134951.1258077615464850610.davem@davemloft.net> (raw)
In-Reply-To: <CADVnQykjK=7cL9pu1EqU+HyiVX_ujSbJ-T1Ohb+M41w4rm1wuA@mail.gmail.com>
From: Neal Cardwell <ncardwell@google.com>
Date: Thu, 23 Aug 2012 13:25:50 -0400
> On Thu, Aug 23, 2012 at 1:21 PM, Nandita Dukkipati <nanditad@google.com> wrote:
>> On Thu, Aug 23, 2012 at 10:05 AM, Yuchung Cheng <ycheng@google.com> wrote:
>>> The cwnd reduction in fast recovery is based on the number of packets
>>> newly delivered per ACK. For non-sack connections every DUPACK
>>> signifies a packet has been delivered, but the sender mistakenly
>>> skips counting them for cwnd reduction.
>>>
>>> The fix is to compute newly_acked_sacked after DUPACKs are accounted
>>> in sacked_out for non-sack connections.
>>>
>>> Signed-off-by: Yuchung Cheng <ycheng@google.com>
...
>> Acked-by: Nandita Dukkipati <nanditad@google.com>
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
Applied, and queued up for -stable, thanks.
Please use plain "tcp: " as the prefix for pure tcp changes. Thanks.
prev parent reply other threads:[~2012-08-24 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 17:05 [PATCH] net-tcp: fix cwnd reduction for non-sack recovery Yuchung Cheng
2012-08-23 17:21 ` Nandita Dukkipati
2012-08-23 17:25 ` Neal Cardwell
2012-08-24 17:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824.134951.1258077615464850610.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=mattmathis@google.com \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).