From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v2 01/10] cgroup: net_cls: Use empty task_cls_classid() when !CONFIG_NET_CLS(_MODULE) Date: Fri, 24 Aug 2012 16:22:07 -0700 Message-ID: <20120824232207.GP21325@google.com> References: <1345816904-21745-1-git-send-email-wagi@monom.org> <1345816904-21745-2-git-send-email-wagi@monom.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Wagner , "David S. Miller" , Gao feng , Jamal Hadi Salim , John Fastabend , Li Zefan , Neil Horman To: Daniel Wagner Return-path: Content-Disposition: inline In-Reply-To: <1345816904-21745-2-git-send-email-wagi-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, Aug 24, 2012 at 04:01:35PM +0200, Daniel Wagner wrote: > From: Daniel Wagner How about, When CONFIG_NET_CLS_CGROUP is N, task_cls_classid() doesn't have any user but the module version still gets defined. Move it inside IS_MODULE(CONFIG_NET_CLS_CGROUP). Thanks. -- tejun