Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: igorm@etf.rs
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipv4: optimize tkey_mismatch
Date: Tue, 28 Aug 2012 14:56:12 -0400 (EDT)	[thread overview]
Message-ID: <20120828.145612.2276726060621764585.davem@davemloft.net> (raw)
In-Reply-To: <1346143938-17167-2-git-send-email-igorm@etf.rs>

From: igorm@etf.rs
Date: Tue, 28 Aug 2012 10:52:18 +0200

> From: Igor Maravic <igorm@etf.rs>
> 
> Optimize tkey_mismatch function by using __fls function.
> 
> Signed-off-by: Igor Maravic <igorm@etf.rs>

This will actually run slower on architectures like sparc that
don't have special instructions for __fls.

Your TOS "optimization" isn't very useful either since having
TOS routes is very rare.

      reply	other threads:[~2012-08-28 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-28  8:52 [PATCH net-next] net: ipv4: Optimize check_leaf function igorm
2012-08-28  8:52 ` [PATCH net-next] net: ipv4: optimize tkey_mismatch igorm
2012-08-28 18:56   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120828.145612.2276726060621764585.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=igorm@etf.rs \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox