Re: [Patch] netpoll: revert 6bdb7fe3104 and fix be_poll() instead

[David Miller <davem@davemloft.net>]

From: Cong Wang <amwang@redhat.com>
Date: Sat, 25 Aug 2012 15:41:11 +0800

> Against -net.
> 
> In the patch "netpoll: re-enable irq in poll_napi()", I tried to
> fix the following warning:
 ...
> by reenabling IRQ before calling ->poll, but it seems more
> problems are introduced after that patch:
> 
> http://ozlabs.org/~akpm/stuff/IMG_20120824_122054.jpg
> http://marc.info/?l=linux-netdev&m=134563282530588&w=2
> 
> So it is safe to fix be2net driver code directly.
> 
> This patch reverts the offending commit and fixes be_poll() by
> avoid disabling BH there, this is okay because be_poll()
> can be called either by poll_napi() which already disables
> IRQ, or by net_rx_action() which already disables BH.
> 
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: Sylvain Munaut <s.munaut@whatever-company.com>
> Cc: Sylvain Munaut <s.munaut@whatever-company.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: David Miller <davem@davemloft.net>
> Cc: Sathya Perla <sathya.perla@emulex.com>
> Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
> Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
> Signed-off-by: Cong Wang <amwang@redhat.com>

Applied, thanks.