From: David Miller <davem@davemloft.net>
To: timur@freescale.com
Cc: afleming@freescale.com, netdev@vger.kernel.org
Subject: Re: [PATCH 5/7] net/fsl_pq_mdio: streamline probing of MDIO nodes
Date: Thu, 30 Aug 2012 13:31:01 -0400 (EDT) [thread overview]
Message-ID: <20120830.133101.155514187705507717.davem@davemloft.net> (raw)
In-Reply-To: <1346263683-3664-5-git-send-email-timur@freescale.com>
From: Timur Tabi <timur@freescale.com>
Date: Wed, 29 Aug 2012 13:08:01 -0500
> Make the device tree probe function more data-driven, so that it no longer
> searches the 'compatible' property more than once. The of_device_id[] array
> allows for per-entry private data, so we use that to store details about each
> type of node that the driver supports. This removes the need to check the
> 'compatible' property inside the probe function.
>
> The driver supports four types on MDIO devices:
>
> 1) Gianfar MDIO nodes that only map the MII registers
> 2) Gianfar MDIO nodes that map the full MDIO register set
> 3) eTSEC2 MDIO nodes (which map the full MDIO register set)
> 4) QE MDIO nodes (which map only the MII registers)
>
> Gianfar, eTSEC2, and QE have different mappings for the TBIPA register, which
> is needed to initialize the TBI PHY. In addition, the QE needs a special
> hack because of the way the device tree is ordered.
>
> All of this information is encapsulated in the fsl_pq_mdio_data structure,
> so when an MDIO node is probed, per-device data and functions are used
> to determine how to initialize the device.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Applied to net-next.
next prev parent reply other threads:[~2012-08-30 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 18:07 [PATCH 1/7] net/freescale: do not export any functions from fsl_pq_mdio.c Timur Tabi
2012-08-29 18:07 ` [PATCH 2/7] net/fsl_pq_mdio: trim #include statements Timur Tabi
2012-08-30 17:30 ` David Miller
2012-08-29 18:07 ` [PATCH 3/7] net/fsl_pq_mdio: merge some functions together Timur Tabi
2012-08-30 17:30 ` David Miller
2012-08-29 18:08 ` [PATCH 4/7] net/fsl_pq_mdio: various small fixes Timur Tabi
2012-08-30 17:30 ` David Miller
2012-08-29 18:08 ` [PATCH 5/7] net/fsl_pq_mdio: streamline probing of MDIO nodes Timur Tabi
2012-08-30 17:31 ` David Miller [this message]
2012-08-29 18:08 ` [PATCH 6/7] net/fsl-pq-mdio: coalesce multiple memory allocations into one Timur Tabi
2012-08-30 17:31 ` David Miller
2012-08-29 18:08 ` [PATCH 7/7] [v2] net/fsl_pq_mdio: add support for the Fman 1G MDIO controller Timur Tabi
2012-08-30 17:31 ` David Miller
2012-08-30 17:30 ` [PATCH 1/7] net/freescale: do not export any functions from fsl_pq_mdio.c David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120830.133101.155514187705507717.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).