From: David Miller <davem@davemloft.net>
To: sony.chacko@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com,
anirban.chakraborty@qlogic.com
Subject: Re: [PATCH 01/12] qlcnic: Refactoring - template based hardware interface
Date: Fri, 31 Aug 2012 16:05:17 -0400 (EDT) [thread overview]
Message-ID: <20120831.160517.226136265278963899.davem@davemloft.net> (raw)
In-Reply-To: <1346394541-3486-2-git-send-email-sony.chacko@qlogic.com>
From: Sony Chacko <sony.chacko@qlogic.com>
Date: Fri, 31 Aug 2012 02:28:50 -0400
> +static inline int
> +qlcnic_config_bridged_mode(struct qlcnic_adapter *adapter, u32 enable)
> +{
> + return adapter->nic_ops->config_bridged_mode(adapter, enable);
> +
> +}
> +
> +static inline int
> +qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 rate)
> +{
> + return adapter->nic_ops->config_led(adapter, state, rate);
> +
> +}
> +
Please get rid of those unnecessary empty lines in the function bodies.
next prev parent reply other threads:[~2012-08-31 20:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 6:28 [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-08-31 6:28 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-08-31 20:05 ` David Miller [this message]
2012-08-31 6:28 ` [PATCH 02/12] qlcnic: Refactoring - Tx/Rx code path separation Sony Chacko
2012-08-31 6:28 ` [PATCH 03/12] qlcnic: Refactoring - Moving hw specific data to hardware context Sony Chacko
2012-08-31 6:28 ` [PATCH 04/12] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-08-31 6:28 ` [PATCH 05/12] qlcnic: change driver firmware interface mechanism Sony Chacko
2012-08-31 6:28 ` [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines Sony Chacko
2012-08-31 6:28 ` [PATCH 07/12] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-08-31 6:28 ` [PATCH 08/12] qlcnic: 83xx CNA inter driver communication mechanism Sony Chacko
2012-08-31 6:28 ` [PATCH 09/12] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-08-31 6:28 ` [PATCH 10/12] qlcnic: register dump utility Sony Chacko
2012-08-31 6:29 ` [PATCH 11/12] qlcnic: 83xx adpater ethtool Sony Chacko
2012-08-31 6:29 ` [PATCH 12/12] qlcnic: update driver version - 5.1.30 Sony Chacko
-- strict thread matches above, loose matches on Subject: below --
2012-08-31 22:36 [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-08-31 22:36 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-09-06 6:21 [PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-09-06 6:21 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-09-07 23:01 [PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-09-07 23:01 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-09-11 1:19 [PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-09-11 1:19 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-09-11 6:01 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831.160517.226136265278963899.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=anirban.chakraborty@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).