Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org, in@joblog.ru
Subject: Re: [PATCH net-next] r8169: add D-Link DGE-560T identifiers.
Date: Fri, 31 Aug 2012 16:28:52 -0400 (EDT)	[thread overview]
Message-ID: <20120831.162852.1143438231808755797.davem@davemloft.net> (raw)
In-Reply-To: <1346308591.17040.20.camel@deadeye.wl.decadent.org.uk>

From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 29 Aug 2012 23:36:31 -0700

> On Wed, 2012-08-29 at 21:40 +0200, Francois Romieu wrote:
>> This one includes a 8168. Not to be confused with the sky2 driven
>> one whose PCI vendor and device ID are the same.
>>
>> Reported-by: Neyuki Inaya <in@joblog.ru>
>> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
>> ---
>> 
>>  The patch applies to Linus's branch as well.
>> 
>>  drivers/net/ethernet/realtek/r8169.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> 
>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index b47d5b3..ab1cc56 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -288,6 +288,8 @@ static DEFINE_PCI_DEVICE_TABLE(rtl8169_pci_tbl) = {
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8168), 0, 0, RTL_CFG_1 },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8169), 0, 0, RTL_CFG_0 },
>>  	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK,	0x4300), 0, 0, RTL_CFG_0 },
>> +	{ PCI_VENDOR_ID_DLINK,			0x4300,
>> +		PCI_VENDOR_ID_DLINK, 0x4b10,		 0, 0, RTL_CFG_1 },
> 
> This has no effect, as the preceding entry will match all the same
> devices.  I think you need to insert it before that.

Francois please fix up this patch, thanks.

  reply	other threads:[~2012-08-31 20:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29 19:40 [PATCH net-next] r8169: add D-Link DGE-560T identifiers Francois Romieu
2012-08-30  6:36 ` Ben Hutchings
2012-08-31 20:28   ` David Miller [this message]
2012-08-31 21:06     ` [PATCH #2 net-next 1/1] " Francois Romieu
2012-08-31 23:59       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831.162852.1143438231808755797.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bhutchings@solarflare.com \
    --cc=in@joblog.ru \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox