From: David Miller <davem@davemloft.net>
To: jbohac@suse.cz
Cc: fubar@us.ibm.com, chris.friesen@genband.com, andy@greyhouse.net,
netdev@vger.kernel.org, ptesarik@suse.cz
Subject: Re: [PATCH] bonding: add some slack to arp monitoring time limits
Date: Fri, 31 Aug 2012 16:37:43 -0400 (EDT) [thread overview]
Message-ID: <20120831.163743.1055530014542819729.davem@davemloft.net> (raw)
In-Reply-To: <20120830220247.GB17263@midget.suse.cz>
From: Jiri Bohac <jbohac@suse.cz>
Date: Fri, 31 Aug 2012 00:02:47 +0200
> Currently, all the time limits in the bonding ARP monitor are in
> multiples of arp_interval -- the time interval at which the ARP
> monitor is periodically scheduled.
>
> With a fast network round-trip and a little scheduling latency
> of the ARP monitor work, a limit of n*delta_in_ticks may
> effectively mean (n-1)*delta_in_ticks.
>
> This is fatal in case of n==1 (the link will stay down
> forever) and makes the behaviour non-deterministic in all the
> other cases.
>
> Add a delta_in_ticks/2 time slack to all the time limits.
>
> Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Applied to net-next, thanks.
prev parent reply other threads:[~2012-08-31 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 17:45 bonding: time limits too tight in bond_ab_arp_inspect Jiri Bohac
2012-08-22 17:54 ` Chris Friesen
2012-08-22 18:42 ` Jay Vosburgh
2012-08-22 18:58 ` Chris Friesen
2012-08-23 7:34 ` Petr Tesarik
2012-08-30 22:02 ` [PATCH] bonding: add some slack to arp monitoring time limits Jiri Bohac
2012-08-31 20:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831.163743.1055530014542819729.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=chris.friesen@genband.com \
--cc=fubar@us.ibm.com \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=ptesarik@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).