From: David Miller <davem@davemloft.net>
To: sony.chacko@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA
Date: Fri, 31 Aug 2012 20:53:08 -0400 (EDT) [thread overview]
Message-ID: <20120831.205308.538476490984218378.davem@davemloft.net> (raw)
In-Reply-To: <20120831.200035.576516635394055754.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 31 Aug 2012 20:00:35 -0400 (EDT)
> From: Sony Chacko <sony.chacko@qlogic.com>
> Date: Fri, 31 Aug 2012 18:36:47 -0400
>
>> Please apply the updated patch series to net-next.
>
> You posted too soon, you received other feedback in the
> mean-time which you should address as well.
Also in patch #5:
- qlcnic_config_ipaddr(adapter, ifa->ifa_address, QLCNIC_IP_UP);
+ qlcnic_config_ipaddr(adapter, ifa->ifa_address,
+ QLCNIC_IP_UP);
This is not the correct way to format multi-line function
calls, the correct way is:
qlcnic_config_ipaddr(adapter, ifa->ifa_address,
QLCNIC_IP_UP);
That is, you line up the first character of the argument to
the column right after the openning parenthesis on the pevious
line, using the appropriate number of TAB and SPACE characters
necessary to achieve that.
next prev parent reply other threads:[~2012-09-01 0:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 22:36 [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-08-31 22:36 ` [PATCH 01/12] qlcnic: Refactoring - template based hardware interface Sony Chacko
2012-08-31 22:36 ` [PATCH 02/12] qlcnic: Refactoring - Tx/Rx code path separation Sony Chacko
2012-08-31 22:36 ` [PATCH 03/12] qlcnic: Refactoring - Moving hw specific data to hardware context Sony Chacko
2012-08-31 22:36 ` [PATCH 04/12] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-08-31 22:36 ` [PATCH 05/12] qlcnic: change driver firmware interface mechanism Sony Chacko
2012-08-31 22:36 ` [PATCH 06/12] qlcnic: 83xx data path and HW interfaces routines Sony Chacko
2012-08-31 22:36 ` [PATCH 07/12] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-08-31 22:36 ` [PATCH 08/12] qlcnic: 83xx CNA inter driver communication mechanism Sony Chacko
2012-08-31 22:36 ` [PATCH 09/12] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-08-31 22:36 ` [PATCH 10/12] qlcnic: register dump utility Sony Chacko
2012-08-31 22:36 ` [PATCH 11/12] qlcnic: 83xx adpater ethtool Sony Chacko
2012-08-31 22:36 ` [PATCH 12/12] qlcnic: update driver version - 5.1.30 Sony Chacko
2012-09-01 0:00 ` [PATCH net-next 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA David Miller
2012-09-01 0:53 ` David Miller [this message]
2012-09-01 1:29 ` Sony Chacko
-- strict thread matches above, loose matches on Subject: below --
2012-08-31 6:28 Sony Chacko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831.205308.538476490984218378.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox