From: David Miller <davem@davemloft.net>
To: chikazawa.akifu@jp.fujitsu.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: when the MTU interface is modified, the promiscuous mode is reset in gianfar driver
Date: Mon, 03 Sep 2012 15:53:32 -0400 (EDT) [thread overview]
Message-ID: <20120903.155332.1814926007061594344.davem@davemloft.net> (raw)
In-Reply-To: <201208270838.AA02326@VF09040P.jp.fujitsu.com>
From: chikazawa.akifu@jp.fujitsu.com (近沢 哲史)
Date: Mon, 27 Aug 2012 17:38:34 +0900
> I am using the gianfar ethernet driver. I am having a problem with the
> interface settings.
> Under promiscuous mode, when the MTU interface is modified, the promiscuous
> mode setting is turned off in gianfar driver when it should not be.
> The details are as follows:
> After changing MTU with ifconfig, I could see that the interface flag of
> eth0 is still PROMISC.
> However, when I checked value of RCTL register with ethtool, PROM bit of
> RTCL register is cleared.
> It seems to be cause that is the gfar_init_mac() function, it doesn't set
> the PROM bit after the interface MTU is changed.
> This problem was detected on linux-2.6.32.2, but it seems to same on
> linux-3.6.0-rc3.
> Is this behavior on purpose?
>
> I also attach the amended file,I think it would be so.
>
> Signed-off-by: Akifumi Chikazawa <chikazawa.akifu@jp.fujitsu.com>
It seems like we also lose all of the multicast configurations as
well.
Therefore, the thing to do is to simply call gfar_set_multi() at the
appropriate location. That will take care of both the promiscuous
bit, as well as the multicast addresses.
You can then remove some of the code in gfar_init_mac() that does
things like gfar_clear_exact_match(), because gfar_set_multi() will
take care of that if necessary.
next prev parent reply other threads:[~2012-09-03 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 8:38 when the MTU interface is modified, the promiscuous mode is reset in gianfar driver 近沢 哲史
2012-09-03 19:53 ` David Miller [this message]
2012-09-05 13:46 ` Claudiu Manoil
2012-09-05 17:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120903.155332.1814926007061594344.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chikazawa.akifu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).