From: David Miller <davem@davemloft.net>
To: oliver@neukum.org
Cc: richardcochran@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: drop unneeded check for NULL
Date: Tue, 04 Sep 2012 12:37:40 -0400 (EDT) [thread overview]
Message-ID: <20120904.123740.1915830868205918256.davem@davemloft.net> (raw)
In-Reply-To: <20747715.9FmHp7X6VE@linux-lqwf.site>
From: Oliver Neukum <oliver@neukum.org>
Date: Tue, 04 Sep 2012 18:13:18 +0200
> If that check is ever needed and tx_fixup not needed, the driver will oops here.
> The check is wrong in any case.
Right, we are dealing with two different things here.
Tree-wide there was a blind set of changes to protect skb_tx_timestamp()
calls with a NULL skb check.
But in this specific case, it's completely unnecessary.
So Oliver's change is definitely correct and I will add it to net-next
Thanks.
next prev parent reply other threads:[~2012-09-04 16:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 14:21 [PATCH] usbnet: drop unneeded check for NULL Oliver Neukum
2012-09-04 15:53 ` Richard Cochran
2012-09-04 16:13 ` Oliver Neukum
2012-09-04 16:37 ` David Miller [this message]
2012-09-05 4:47 ` Richard Cochran
2012-09-05 6:24 ` Oliver Neukum
2012-09-05 16:50 ` David Miller
2012-09-05 22:14 ` Ben Hutchings
2012-09-05 22:34 ` Oliver Neukum
2012-09-05 22:53 ` Ben Hutchings
2012-09-06 7:52 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904.123740.1915830868205918256.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).