From: David Miller <davem@davemloft.net>
To: ja@ssi.bg
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
shemminger@vyatta.com, paulmck@linux.vnet.ibm.com
Subject: Re: [PATCH v2 1/2] tcp: add generic netlink support for tcp_metrics
Date: Tue, 04 Sep 2012 15:47:08 -0400 (EDT) [thread overview]
Message-ID: <20120904.154708.2099268692603008096.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1209031041340.1663@ja.ssi.bg>
From: Julian Anastasov <ja@ssi.bg>
Date: Mon, 3 Sep 2012 11:22:15 +0300 (EEST)
> BTW, is it appropriate to use kmem_cache for
> metrics and as result call_rcu for freeing?
I think it would work as things are implemented currently in
slab/slub/slob, however I would not rely upon it.
If you do move to a SLAB cache for the tcp metrics objects,
you might consider SLAB_DESTROY_BY_RCU. It's a very delicate
facility (read the huge comment in linux/slab.h) but I think
it provides the semantics we need for TCP metrics blobs.
Looking forward to v3 :-)
next prev parent reply other threads:[~2012-09-04 19:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 5:36 [PATCH v2 0/2] Interface for TCP Metrics Julian Anastasov
2012-09-02 5:36 ` [PATCH v2 1/2] tcp: add generic netlink support for tcp_metrics Julian Anastasov
2012-09-03 0:45 ` Eric Dumazet
2012-09-03 8:22 ` Julian Anastasov
2012-09-04 19:47 ` David Miller [this message]
2012-09-04 21:00 ` Julian Anastasov
2012-09-02 5:36 ` [PATCH v2 2/2] iproute2: add " Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904.154708.2099268692603008096.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).