From: Richard Cochran <richardcochran@gmail.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
Oliver Neukum <oneukum@suse.de>
Subject: Re: [PATCH] usbnet: drop unneeded check for NULL
Date: Tue, 4 Sep 2012 17:53:43 +0200 [thread overview]
Message-ID: <20120904155343.GA2170@netboy.at.omicron.at> (raw)
In-Reply-To: <1346768514-19823-1-git-send-email-oliver@neukum.org>
On Tue, Sep 04, 2012 at 04:21:54PM +0200, Oliver Neukum wrote:
> usbnet_start_xmit() is always called with a valid skb
So, has the problem that this test worked around been fixed?
Thanks,
Richard
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
> ---
> drivers/net/usb/usbnet.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 8531c1c..5234d20 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -1092,8 +1092,7 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
> unsigned long flags;
> int retval;
>
> - if (skb)
> - skb_tx_timestamp(skb);
> + skb_tx_timestamp(skb);
>
> // some devices want funky USB-level framing, for
> // win32 driver (usually) and/or hardware quirks
> --
> 1.7.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-04 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 14:21 [PATCH] usbnet: drop unneeded check for NULL Oliver Neukum
2012-09-04 15:53 ` Richard Cochran [this message]
2012-09-04 16:13 ` Oliver Neukum
2012-09-04 16:37 ` David Miller
2012-09-05 4:47 ` Richard Cochran
2012-09-05 6:24 ` Oliver Neukum
2012-09-05 16:50 ` David Miller
2012-09-05 22:14 ` Ben Hutchings
2012-09-05 22:34 ` Oliver Neukum
2012-09-05 22:53 ` Ben Hutchings
2012-09-06 7:52 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120904155343.GA2170@netboy.at.omicron.at \
--to=richardcochran@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).