From: David Miller <davem@davemloft.net>
To: oneukum@suse.de
Cc: richardcochran@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: drop unneeded check for NULL
Date: Wed, 05 Sep 2012 12:50:16 -0400 (EDT) [thread overview]
Message-ID: <20120905.125016.2259674613767082102.davem@davemloft.net> (raw)
In-Reply-To: <2037108.ZemStJh9zr@linux-lqwf.site>
From: Oliver Neukum <oneukum@suse.de>
Date: Wed, 05 Sep 2012 08:24:25 +0200
> On Wednesday 05 September 2012 06:47:12 Richard Cochran wrote:
>> and so I think the problem that the test addresses is still present,
>> or am I missing something?
>
> No,
>
> you are right. Thank you.
>
> Dave, for now, please don't apply this patch. In the long run, this crap
> in cdc-ncm needs to go. I am starting rewriting this driver right now.
I already applied it several days ago, someone send me a revert with a
verbose commit message explaining the situation.
next prev parent reply other threads:[~2012-09-05 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 14:21 [PATCH] usbnet: drop unneeded check for NULL Oliver Neukum
2012-09-04 15:53 ` Richard Cochran
2012-09-04 16:13 ` Oliver Neukum
2012-09-04 16:37 ` David Miller
2012-09-05 4:47 ` Richard Cochran
2012-09-05 6:24 ` Oliver Neukum
2012-09-05 16:50 ` David Miller [this message]
2012-09-05 22:14 ` Ben Hutchings
2012-09-05 22:34 ` Oliver Neukum
2012-09-05 22:53 ` Ben Hutchings
2012-09-06 7:52 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905.125016.2259674613767082102.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).