From: David Miller <davem@davemloft.net>
To: oliver@neukum.org
Cc: netdev@vger.kernel.org, oneukum@suse.de
Subject: Re: [PATCH] Revert "usbnet: drop unneeded check for NULL"
Date: Wed, 05 Sep 2012 16:20:46 -0400 (EDT) [thread overview]
Message-ID: <20120905.162046.1293290557238046936.davem@davemloft.net> (raw)
In-Reply-To: <1346872952-21192-1-git-send-email-oliver@neukum.org>
From: Oliver Neukum <oliver@neukum.org>
Date: Wed, 5 Sep 2012 21:22:32 +0200
> This reverts commit 5d65878d7031b6c39054b282faceff406bb2fda9.
> The upper layers call usbnet_start_xmit() with a valid skb.
> However cdc_ncm abuses this method by calling it with NULL
> to trigger IO for the aggregated private skb holding erlier
> packets. Until cdc_ncm is fixed, the check for NULL must
> be reintroduced.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
Applied, thanks Oliver.
prev parent reply other threads:[~2012-09-05 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 19:22 [PATCH] Revert "usbnet: drop unneeded check for NULL" Oliver Neukum
2012-09-05 20:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905.162046.1293290557238046936.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox