From: David Miller <davem@davemloft.net>
To: naleksan@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: add unknown state to sysfs NIC duplex export
Date: Wed, 05 Sep 2012 17:40:55 -0400 (EDT) [thread overview]
Message-ID: <20120905.174055.2000797689147082508.davem@davemloft.net> (raw)
In-Reply-To: <1346854288-6380-1-git-send-email-naleksan@redhat.com>
From: Nikolay Aleksandrov <naleksan@redhat.com>
Date: Wed, 5 Sep 2012 16:11:28 +0200
> Currently when the NIC duplex state is DUPLEX_UNKNOWN it is exported as
> full through sysfs, this patch adds support for DUPLEX_UNKNOWN. It is
> handled the same way as in ethtool.
>
> Signed-off-by: Nikolay Aleksandrov <naleksan@redhat.com>
Applied with two minor corrections:
> + char *duplex;
I made this "const char *"
> + switch(cmd.duplex) {
I added the missing space between 'switch' and '(cmd.duplex)'.
Thanks.
prev parent reply other threads:[~2012-09-05 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 14:11 [PATCH] net: add unknown state to sysfs NIC duplex export Nikolay Aleksandrov
2012-09-05 21:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905.174055.2000797689147082508.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=naleksan@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).