* [PATCH] bnx2x: use list_move_tail instead of list_del/list_add_tail
@ 2012-09-05 7:06 Wei Yongjun
2012-09-05 21:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-05 7:06 UTC (permalink / raw)
To: eilong; +Cc: yongjun_wei, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
index 62f754b..5a5fbf5 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -229,8 +229,7 @@ static inline int bnx2x_exe_queue_step(struct bnx2x *bp,
*/
list_add_tail(&spacer.link, &o->pending_comp);
mb();
- list_del(&elem->link);
- list_add_tail(&elem->link, &o->pending_comp);
+ list_move_tail(&elem->link, &o->pending_comp);
list_del(&spacer.link);
} else
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bnx2x: use list_move_tail instead of list_del/list_add_tail
2012-09-05 7:06 [PATCH] bnx2x: use list_move_tail instead of list_del/list_add_tail Wei Yongjun
@ 2012-09-05 21:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-09-05 21:50 UTC (permalink / raw)
To: weiyj.lk; +Cc: eilong, yongjun_wei, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Wed, 5 Sep 2012 15:06:55 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_move_tail() instead of list_del() + list_add_tail().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-05 21:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-05 7:06 [PATCH] bnx2x: use list_move_tail instead of list_del/list_add_tail Wei Yongjun
2012-09-05 21:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).