From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org
Subject: Re: [RFC PATCH v3] ipv6: fix handling of blackhole and prohibit routes
Date: Wed, 05 Sep 2012 17:50:52 -0400 (EDT) [thread overview]
Message-ID: <20120905.175052.246018302031393962.davem@davemloft.net> (raw)
In-Reply-To: <1346847162-3558-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Wed, 5 Sep 2012 08:12:42 -0400
> When adding a blackhole or a prohibit route, they were handling like classic
> routes. Moreover, it was only possible to add this kind of routes by specifying
> an interface.
>
> Bug already reported here:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498498
>
> Before the patch:
> $ ip route add blackhole 2001::1/128
> RTNETLINK answers: No such device
> $ ip route add blackhole 2001::1/128 dev eth0
> $ ip -6 route | grep 2001
> 2001::1 dev eth0 metric 1024
>
> After:
> $ ip route add blackhole 2001::1/128
> $ ip -6 route | grep 2001
> blackhole 2001::1 dev lo metric 1024 error -22
>
> v2: wrong patch
> v3: add a field fc_type in struct fib6_config to store RTN_* type
>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
I like this a lot more than your original patch, applied to net-next,
thanks.
prev parent reply other threads:[~2012-09-05 21:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 14:29 [RFC PATCH] ipv6: fix handling of blackhole and prohibit routes Nicolas Dichtel
2012-09-04 19:58 ` David Miller
2012-09-05 11:34 ` [RFC PATCH v2] " Nicolas Dichtel
2012-09-05 10:03 ` Nicolas Dichtel
2012-09-05 12:12 ` [RFC PATCH v3] " Nicolas Dichtel
2012-09-05 21:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120905.175052.246018302031393962.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).