From: Jean Delvare <khali@linux-fr.org>
To: netdev@vger.kernel.org
Subject: |PATCH] seeq: Add missing spinlock init
Date: Thu, 6 Sep 2012 12:47:05 +0200 [thread overview]
Message-ID: <20120906124705.2631ae01@endymion.delvare> (raw)
It doesn't seem this spinlock was properly initialized.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
I can't even build-test this.
drivers/net/ethernet/seeq/sgiseeq.c | 1 +
1 file changed, 1 insertion(+)
--- linux-3.6-rc4.orig/drivers/net/ethernet/seeq/sgiseeq.c 2012-07-21 22:58:29.000000000 +0200
+++ linux-3.6-rc4/drivers/net/ethernet/seeq/sgiseeq.c 2012-09-06 12:40:30.092144722 +0200
@@ -751,6 +751,7 @@ static int __devinit sgiseeq_probe(struc
sp->srings = sr;
sp->rx_desc = sp->srings->rxvector;
sp->tx_desc = sp->srings->txvector;
+ spin_lock_init(&sp->tx_lock);
/* A couple calculations now, saves many cycles later. */
setup_rx_ring(dev, sp->rx_desc, SEEQ_RX_BUFFERS);
--
Jean Delvare
next reply other threads:[~2012-09-06 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 10:47 Jean Delvare [this message]
2012-09-07 16:59 ` |PATCH] seeq: Add missing spinlock init David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120906124705.2631ae01@endymion.delvare \
--to=khali@linux-fr.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox