* |PATCH] seeq: Add missing spinlock init
@ 2012-09-06 10:47 Jean Delvare
2012-09-07 16:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2012-09-06 10:47 UTC (permalink / raw)
To: netdev
It doesn't seem this spinlock was properly initialized.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
I can't even build-test this.
drivers/net/ethernet/seeq/sgiseeq.c | 1 +
1 file changed, 1 insertion(+)
--- linux-3.6-rc4.orig/drivers/net/ethernet/seeq/sgiseeq.c 2012-07-21 22:58:29.000000000 +0200
+++ linux-3.6-rc4/drivers/net/ethernet/seeq/sgiseeq.c 2012-09-06 12:40:30.092144722 +0200
@@ -751,6 +751,7 @@ static int __devinit sgiseeq_probe(struc
sp->srings = sr;
sp->rx_desc = sp->srings->rxvector;
sp->tx_desc = sp->srings->txvector;
+ spin_lock_init(&sp->tx_lock);
/* A couple calculations now, saves many cycles later. */
setup_rx_ring(dev, sp->rx_desc, SEEQ_RX_BUFFERS);
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: |PATCH] seeq: Add missing spinlock init
2012-09-06 10:47 |PATCH] seeq: Add missing spinlock init Jean Delvare
@ 2012-09-07 16:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-09-07 16:59 UTC (permalink / raw)
To: khali; +Cc: netdev
From: Jean Delvare <khali@linux-fr.org>
Date: Thu, 6 Sep 2012 12:47:05 +0200
> It doesn't seem this spinlock was properly initialized.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-07 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-06 10:47 |PATCH] seeq: Add missing spinlock init Jean Delvare
2012-09-07 16:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).