netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: eric.dumazet@gmail.com, vyasevich@gmail.com, sri@us.ibm.com,
	linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] dst: take into account policy update on check()
Date: Fri, 07 Sep 2012 14:48:28 -0400 (EDT)	[thread overview]
Message-ID: <20120907.144828.97793990734588625.davem@davemloft.net> (raw)
In-Reply-To: <504A0F1F.5060504@6wind.com>

From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Fri, 07 Sep 2012 17:13:35 +0200

> Le 07/09/2012 17:09, Eric Dumazet a écrit :
>> On Fri, 2012-09-07 at 16:47 +0200, Nicolas Dichtel wrote:
>>> Le 07/09/2012 16:35, Eric Dumazet a écrit :
>>>>
>>>> Hmm... cant we reuse rt_genid ?
>>>>
>>>> (When changing flow_cache_genid, change &net->ipv4.rt_genid)
>>>
>>> And so adding a new field in net->ipv6?
>>
>> or move net->ipv4.rt_genid to net->rt_genid
>>
>> Having separate field for IPv4/IPv6 is of little interest IMHO
>>
> Ok, I will wait feedback from other people and repost a patch after.

A global net->rt_genid is definitely the way to go.

  parent reply	other threads:[~2012-09-07 18:48 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06 17:40 [PATCH] sctp: check dst validity after IPsec operations Nicolas Dichtel
2012-09-06 16:04 ` Vlad Yasevich
2012-09-06 16:40   ` Nicolas Dichtel
2012-09-06 17:03     ` Vlad Yasevich
2012-09-07 12:24       ` Nicolas Dichtel
2012-09-07 12:07   ` Nicolas Dichtel
2012-09-06 18:10 ` David Miller
2012-09-07 13:47   ` Nicolas Dichtel
2012-09-07 15:57     ` [PATCH RFC net-next 0/2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-07 15:57       ` [PATCH 1/2] dst: take into account policy update on check() Nicolas Dichtel
2012-09-07 14:20         ` Vlad Yasevich
2012-09-07 14:35         ` Eric Dumazet
2012-09-07 14:47           ` Nicolas Dichtel
2012-09-07 15:09             ` Eric Dumazet
2012-09-07 15:13               ` Nicolas Dichtel
2012-09-07 15:21                 ` Eric Dumazet
2012-09-07 18:48                   ` David Miller
2012-09-07 18:48                 ` David Miller [this message]
2012-09-10 12:47                   ` Nicolas Dichtel
2012-09-10 13:10                     ` Eric Dumazet
2012-09-10 13:22                   ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-10 13:22                     ` [PATCH net-next v2 1/4] netns: move net->ipv4.rt_genid to net->rt_genid Nicolas Dichtel
2012-09-10 13:22                     ` [PATCH net-next v2 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-10 14:21                       ` Vlad Yasevich
2012-09-10 14:56                         ` Nicolas Dichtel
2012-09-11  8:09                           ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 1/4] netns: move net->ipv4.rt_genid to net->rt_genid Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 2/4] xfrm: invalidate dst on policy insertion/deletion Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-11  8:09                             ` [PATCH net-next v3 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-12  7:40                               ` Eric Dumazet
2012-09-17 16:49                             ` [PATCH net-next v3 0/4] Take care of xfrm policy when checking dst entries David Miller
2012-09-17 18:14                               ` Vlad Yasevich
2012-09-17 18:25                                 ` David Miller
2012-09-17 19:52                                   ` Nicolas Dichtel
2012-09-17 19:54                                     ` David Miller
2012-09-18 20:08                                       ` David Miller
2012-09-10 13:22                     ` [PATCH net-next v2 3/4] ipv6: use net->rt_genid to check dst validity Nicolas Dichtel
2012-09-10 14:29                       ` Vlad Yasevich
2012-09-10 14:34                         ` Nicolas Dichtel
2012-09-10 14:43                           ` Vlad Yasevich
2012-09-10 14:44                             ` Nicolas Dichtel
2012-09-10 13:22                     ` [PATCH net-next v2 4/4] ipv6: use DST_* macro to set obselete field Nicolas Dichtel
2012-09-10 14:35                     ` [PATCH net-next v2] Take care of xfrm policy when checking dst entries Vlad Yasevich
2012-09-10 14:38                       ` Nicolas Dichtel
2012-09-10 17:18                       ` David Miller
2012-09-10 17:59                         ` Vlad Yasevich
2012-09-10 18:01                           ` David Miller
2012-09-22 16:49                             ` Jan Engelhardt
2012-09-07 14:51           ` [PATCH 1/2] dst: take into account policy update on check() Vlad Yasevich
2012-09-07 15:08             ` Eric Dumazet
2012-09-07 15:57       ` [PATCH 2/2] ipv6: remove rt6i_flow_cache_genid field in rt6_info Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120907.144828.97793990734588625.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=sri@us.ibm.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).