* [PATCH] caif: move the dereference below the NULL test
@ 2012-09-10 4:38 Wei Yongjun
2012-09-10 20:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-10 4:38 UTC (permalink / raw)
To: sjur.brandeland, davem; +Cc: yongjun_wei, netdev
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
net/caif/cfsrvl.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/caif/cfsrvl.c b/net/caif/cfsrvl.c
index dd485f6..ba217e9 100644
--- a/net/caif/cfsrvl.c
+++ b/net/caif/cfsrvl.c
@@ -211,9 +211,10 @@ void caif_client_register_refcnt(struct cflayer *adapt_layer,
void (*put)(struct cflayer *lyr))
{
struct cfsrvl *service;
- service = container_of(adapt_layer->dn, struct cfsrvl, layer);
- WARN_ON(adapt_layer == NULL || adapt_layer->dn == NULL);
+ if (WARN_ON(adapt_layer == NULL || adapt_layer->dn == NULL))
+ return;
+ service = container_of(adapt_layer->dn, struct cfsrvl, layer);
service->hold = hold;
service->put = put;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] caif: move the dereference below the NULL test
2012-09-10 4:38 [PATCH] caif: move the dereference below the NULL test Wei Yongjun
@ 2012-09-10 20:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-09-10 20:14 UTC (permalink / raw)
To: weiyj.lk; +Cc: sjur.brandeland, yongjun_wei, netdev
From: Wei Yongjun <weiyj.lk@gmail.com>
Date: Mon, 10 Sep 2012 12:38:27 +0800
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The dereference should be moved below the NULL test.
>
> spatch with a semantic match is used to found this.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-10 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-10 4:38 [PATCH] caif: move the dereference below the NULL test Wei Yongjun
2012-09-10 20:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).