From: David Miller <davem@davemloft.net>
To: florian@openwrt.org
Cc: netdev@vger.kernel.org, khc@pm.waw.pl, joe@perches.com,
stable@vger.kernel.org
Subject: Re: [PATCH net v2] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion
Date: Mon, 10 Sep 2012 16:15:43 -0400 (EDT) [thread overview]
Message-ID: <20120910.161543.255714089600943802.davem@davemloft.net> (raw)
In-Reply-To: <1347278818-6913-1-git-send-email-florian@openwrt.org>
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 10 Sep 2012 14:06:58 +0200
> Commit 36a1211970193ce215de50ed1e4e1272bc814df1 (netprio_cgroup.h:
> dont include module.h from other includes) made the following build
> error on ixp4xx_hss pop up:
>
> CC [M] drivers/net/wan/ixp4xx_hss.o
> drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')'
> before string constant
> drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')'
> before string constant
> drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')'
> before string constant
> drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')'
> before string constant
> make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1
>
> This was previously hidden because ixp4xx_hss includes linux/hdlc.h which
> includes linux/netdevice.h which includes linux/netprio_cgroup.h which
> used to include linux/module.h. The real issue was actually present since
> the initial commit that added this driver since it uses macros from
> linux/module.h without including this file.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2012-09-10 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 12:06 [PATCH net v2] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion Florian Fainelli
2012-09-10 20:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120910.161543.255714089600943802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=joe@perches.com \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).