* [PATCH net v2] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion
@ 2012-09-10 12:06 Florian Fainelli
2012-09-10 20:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2012-09-10 12:06 UTC (permalink / raw)
To: netdev; +Cc: khc, joe, David Miller, Florian Fainelli, stable
Commit 36a1211970193ce215de50ed1e4e1272bc814df1 (netprio_cgroup.h:
dont include module.h from other includes) made the following build
error on ixp4xx_hss pop up:
CC [M] drivers/net/wan/ixp4xx_hss.o
drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')'
before string constant
drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')'
before string constant
drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')'
before string constant
drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')'
before string constant
make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1
This was previously hidden because ixp4xx_hss includes linux/hdlc.h which
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.
CC: stable@vger.kernel.org
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
[stable: 3.3+]
Changes since v1:
- properly identify the bad commit
drivers/net/wan/ixp4xx_hss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wan/ixp4xx_hss.c b/drivers/net/wan/ixp4xx_hss.c
index aaaca9a..3f575af 100644
--- a/drivers/net/wan/ixp4xx_hss.c
+++ b/drivers/net/wan/ixp4xx_hss.c
@@ -10,6 +10,7 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#include <linux/module.h>
#include <linux/bitops.h>
#include <linux/cdev.h>
#include <linux/dma-mapping.h>
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v2] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion
2012-09-10 12:06 [PATCH net v2] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion Florian Fainelli
@ 2012-09-10 20:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-09-10 20:15 UTC (permalink / raw)
To: florian; +Cc: netdev, khc, joe, stable
From: Florian Fainelli <florian@openwrt.org>
Date: Mon, 10 Sep 2012 14:06:58 +0200
> Commit 36a1211970193ce215de50ed1e4e1272bc814df1 (netprio_cgroup.h:
> dont include module.h from other includes) made the following build
> error on ixp4xx_hss pop up:
>
> CC [M] drivers/net/wan/ixp4xx_hss.o
> drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')'
> before string constant
> drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')'
> before string constant
> drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')'
> before string constant
> drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')'
> before string constant
> make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1
>
> This was previously hidden because ixp4xx_hss includes linux/hdlc.h which
> includes linux/netdevice.h which includes linux/netprio_cgroup.h which
> used to include linux/module.h. The real issue was actually present since
> the initial commit that added this driver since it uses macros from
> linux/module.h without including this file.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-10 20:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-10 12:06 [PATCH net v2] ixp4xx_hss: fix build failure due to missing linux/module.h inclusion Florian Fainelli
2012-09-10 20:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).