* [PATCH 1/1] [PATCH] net: qmi_wwan: fix Gobi device probing for un2430
@ 2012-09-10 17:02 pierre.sauter
2012-09-10 20:43 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: pierre.sauter @ 2012-09-10 17:02 UTC (permalink / raw)
To: gregkh; +Cc: netdev, Pierre Sauter
From: Pierre Sauter <pierre.sauter@gmail.com>
HP un2430 is a Gobi 3000 device. It was mistakenly treated as Gobi 1000
in patch b9f90eb2740203ff2592efe640409ad48335d1c2.
I own this device and qmi_wwan works again with this fix.
Signed-off-by: Pierre Sauter <pierre.sauter@gmail.com>
---
drivers/net/usb/qmi_wwan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index adfab3f..17b8f3e 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -398,7 +398,6 @@ static const struct usb_device_id products[] = {
/* 4. Gobi 1000 devices */
{QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
{QMI_GOBI1K_DEVICE(0x03f0, 0x1f1d)}, /* HP un2400 Gobi Modem Device */
- {QMI_GOBI1K_DEVICE(0x03f0, 0x371d)}, /* HP un2430 Mobile Broadband Module */
{QMI_GOBI1K_DEVICE(0x04da, 0x250d)}, /* Panasonic Gobi Modem device */
{QMI_GOBI1K_DEVICE(0x413c, 0x8172)}, /* Dell Gobi Modem device */
{QMI_GOBI1K_DEVICE(0x1410, 0xa001)}, /* Novatel Gobi Modem device */
@@ -440,6 +439,7 @@ static const struct usb_device_id products[] = {
{QMI_GOBI_DEVICE(0x16d8, 0x8002)}, /* CMDTech Gobi 2000 Modem device (VU922) */
{QMI_GOBI_DEVICE(0x05c6, 0x9205)}, /* Gobi 2000 Modem device */
{QMI_GOBI_DEVICE(0x1199, 0x9013)}, /* Sierra Wireless Gobi 3000 Modem device (MC8355) */
+ {QMI_GOBI_DEVICE(0x03f0, 0x371d)}, /* HP un2430 Mobile Broadband Module */
{QMI_GOBI_DEVICE(0x1199, 0x9015)}, /* Sierra Wireless Gobi 3000 Modem device */
{QMI_GOBI_DEVICE(0x1199, 0x9019)}, /* Sierra Wireless Gobi 3000 Modem device */
{QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] [PATCH] net: qmi_wwan: fix Gobi device probing for un2430
2012-09-10 17:02 [PATCH 1/1] [PATCH] net: qmi_wwan: fix Gobi device probing for un2430 pierre.sauter
@ 2012-09-10 20:43 ` David Miller
2012-09-11 4:59 ` Bjørn Mork
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2012-09-10 20:43 UTC (permalink / raw)
To: pierre.sauter; +Cc: gregkh, netdev, bjorn
From: pierre.sauter@gmail.com
Date: Mon, 10 Sep 2012 19:02:59 +0200
> From: Pierre Sauter <pierre.sauter@gmail.com>
>
> HP un2430 is a Gobi 3000 device. It was mistakenly treated as Gobi 1000
> in patch b9f90eb2740203ff2592efe640409ad48335d1c2.
>
> I own this device and qmi_wwan works again with this fix.
>
> Signed-off-by: Pierre Sauter <pierre.sauter@gmail.com>
Bjorn, ACK/NACK?
> ---
> drivers/net/usb/qmi_wwan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index adfab3f..17b8f3e 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -398,7 +398,6 @@ static const struct usb_device_id products[] = {
> /* 4. Gobi 1000 devices */
> {QMI_GOBI1K_DEVICE(0x05c6, 0x9212)}, /* Acer Gobi Modem Device */
> {QMI_GOBI1K_DEVICE(0x03f0, 0x1f1d)}, /* HP un2400 Gobi Modem Device */
> - {QMI_GOBI1K_DEVICE(0x03f0, 0x371d)}, /* HP un2430 Mobile Broadband Module */
> {QMI_GOBI1K_DEVICE(0x04da, 0x250d)}, /* Panasonic Gobi Modem device */
> {QMI_GOBI1K_DEVICE(0x413c, 0x8172)}, /* Dell Gobi Modem device */
> {QMI_GOBI1K_DEVICE(0x1410, 0xa001)}, /* Novatel Gobi Modem device */
> @@ -440,6 +439,7 @@ static const struct usb_device_id products[] = {
> {QMI_GOBI_DEVICE(0x16d8, 0x8002)}, /* CMDTech Gobi 2000 Modem device (VU922) */
> {QMI_GOBI_DEVICE(0x05c6, 0x9205)}, /* Gobi 2000 Modem device */
> {QMI_GOBI_DEVICE(0x1199, 0x9013)}, /* Sierra Wireless Gobi 3000 Modem device (MC8355) */
> + {QMI_GOBI_DEVICE(0x03f0, 0x371d)}, /* HP un2430 Mobile Broadband Module */
> {QMI_GOBI_DEVICE(0x1199, 0x9015)}, /* Sierra Wireless Gobi 3000 Modem device */
> {QMI_GOBI_DEVICE(0x1199, 0x9019)}, /* Sierra Wireless Gobi 3000 Modem device */
> {QMI_GOBI_DEVICE(0x1199, 0x901b)}, /* Sierra Wireless MC7770 */
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] [PATCH] net: qmi_wwan: fix Gobi device probing for un2430
2012-09-10 20:43 ` David Miller
@ 2012-09-11 4:59 ` Bjørn Mork
2012-09-11 5:10 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Bjørn Mork @ 2012-09-11 4:59 UTC (permalink / raw)
To: David Miller, pierre.sauter; +Cc: gregkh, netdev
David Miller <davem@davemloft.net> wrote:
>From: pierre.sauter@gmail.com
>Date: Mon, 10 Sep 2012 19:02:59 +0200
>
>> From: Pierre Sauter <pierre.sauter@gmail.com>
>>
>> HP un2430 is a Gobi 3000 device. It was mistakenly treated as Gobi
>1000
>> in patch b9f90eb2740203ff2592efe640409ad48335d1c2.
>>
>> I own this device and qmi_wwan works again with this fix.
>>
>> Signed-off-by: Pierre Sauter <pierre.sauter@gmail.com>
>
>Bjorn, ACK/NACK?
Acked-by: Bjørn Mork <bjorn@mork.no>
Thanks for fixing this, Pierre. I wonder how I managed to get this wrong. Better look it all over again, I guess...
Bjørn
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] [PATCH] net: qmi_wwan: fix Gobi device probing for un2430
2012-09-11 4:59 ` Bjørn Mork
@ 2012-09-11 5:10 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2012-09-11 5:10 UTC (permalink / raw)
To: bjorn; +Cc: pierre.sauter, gregkh, netdev
From: Bjørn Mork <bjorn@mork.no>
Date: Tue, 11 Sep 2012 06:59:57 +0200
> David Miller <davem@davemloft.net> wrote:
>
>>From: pierre.sauter@gmail.com
>>Date: Mon, 10 Sep 2012 19:02:59 +0200
>>
>>> From: Pierre Sauter <pierre.sauter@gmail.com>
>>>
>>> HP un2430 is a Gobi 3000 device. It was mistakenly treated as Gobi
>>1000
>>> in patch b9f90eb2740203ff2592efe640409ad48335d1c2.
>>>
>>> I own this device and qmi_wwan works again with this fix.
>>>
>>> Signed-off-by: Pierre Sauter <pierre.sauter@gmail.com>
>>
>>Bjorn, ACK/NACK?
>
> Acked-by: Bjørn Mork <bjorn@mork.no>
>
> Thanks for fixing this, Pierre. I wonder how I managed to get this
> wrong. Better look it all over again, I guess...
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-09-11 5:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-10 17:02 [PATCH 1/1] [PATCH] net: qmi_wwan: fix Gobi device probing for un2430 pierre.sauter
2012-09-10 20:43 ` David Miller
2012-09-11 4:59 ` Bjørn Mork
2012-09-11 5:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).