netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: netlink: hide struct module parameter in netlink_kernel_create
@ 2012-09-09 23:37 Stephen Rothwell
  2012-09-10  7:45 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Rothwell @ 2012-09-09 23:37 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: David S. Miller, netdev

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

Hi all,

I didn't see the original patch until it reached linux-enxt this morning,
but just a comment:

THIS_MODULE is defined in linux/export.h, so that should be included in
linux/netlink.h instead of linux/module.h as it is much smaller.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: netlink: hide struct module parameter in netlink_kernel_create
  2012-09-09 23:37 netlink: hide struct module parameter in netlink_kernel_create Stephen Rothwell
@ 2012-09-10  7:45 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2012-09-10  7:45 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: David S. Miller, netdev

On Mon, Sep 10, 2012 at 09:37:12AM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> I didn't see the original patch until it reached linux-enxt this morning,
> but just a comment:
> 
> THIS_MODULE is defined in linux/export.h, so that should be included in
> linux/netlink.h instead of linux/module.h as it is much smaller.

I'll send a follow-up patch for this to David, thanks Stephen.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-10  7:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-09 23:37 netlink: hide struct module parameter in netlink_kernel_create Stephen Rothwell
2012-09-10  7:45 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).