netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: shlomop@mellanox.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: GRO aggregation
Date: Tue, 11 Sep 2012 15:35:00 -0400 (EDT)	[thread overview]
Message-ID: <20120911.153500.773448380897956568.davem@davemloft.net> (raw)
In-Reply-To: <36F7E4A28C18BE4DB7C86058E7B607241E622083@MTRDAG01.mtl.com>

From: Shlomo Pongratz <shlomop@mellanox.com>
Date: Tue, 11 Sep 2012 19:24:26 +0000

> I see that in ixgbe the weight for the NAPI is 64
> (netif_napi_add). So if packets are arriving in high rate then an
> the CPU is fast enough to collect the packets as they arrive,
> assuming packets continue to arrives while the NAPI runs. Then it
> should have aggregate more. So we will have less passes trough the
> stack.

Eric is trying to say that that cpu is fast enough that it completely
depletes the pending RX packets, the RX queue is empty, and there is
only 32K worth of GRO to accumulate.

BTW, your email quoting is non-standard and very confusing.  There
is absolutely no delineation between the text that you are writing
and the text of the people you are responding too.  Please learn how
to write email replies properly.

Thank you.

  reply	other threads:[~2012-09-11 19:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 13:45 GRO aggregation Shlomo Pongartz
2012-09-11 18:20 ` Marcelo Ricardo Leitner
2012-09-11 18:41   ` Shlomo Pongratz
2012-09-11 18:48     ` Marcelo Ricardo Leitner
2012-09-11 18:51       ` Shlomo Pongratz
2012-09-11 18:33 ` Eric Dumazet
2012-09-11 18:49   ` Shlomo Pongratz
2012-09-11 19:01     ` Eric Dumazet
2012-09-11 19:24       ` Shlomo Pongratz
2012-09-11 19:35         ` David Miller [this message]
2012-09-11 19:35         ` Eric Dumazet
2012-09-12  9:23           ` Shlomo Pongartz
2012-09-12  9:33             ` Eric Dumazet
2012-09-12 14:41               ` Shlomo Pongartz
2012-09-12 16:23                 ` Rick Jones
2012-09-12 16:34                   ` Shlomo Pongartz
2012-09-12 16:52                     ` Rick Jones
2012-09-13  6:36                       ` Shlomo Pongartz
2012-09-13  8:11                         ` Eric Dumazet
2012-09-13  9:59                           ` Or Gerlitz
2012-09-13 12:05                             ` Eric Dumazet
2012-09-13 12:34                               ` Eric Dumazet
2012-09-13 12:47                               ` Or Gerlitz
2012-09-13 13:22                                 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911.153500.773448380897956568.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shlomop@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).