From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 7/8] cgroup: Assign subsystem IDs during compile time Date: Tue, 11 Sep 2012 14:36:46 -0700 Message-ID: <20120911213646.GF7677@google.com> References: <1347380774-9546-1-git-send-email-wagi@monom.org> <1347380774-9546-8-git-send-email-wagi@monom.org> <20120911210109.GZ7677@google.com> <20120911210821.GB7677@google.com> <504FADC1.4060503@monom.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Wagner , "David S. Miller" , Andrew Morton , Eric Dumazet , Gao feng , Glauber Costa , Jamal Hadi Salim , John Fastabend , Kamezawa Hiroyuki , Li Zefan , Neil Horman To: Daniel Wagner Return-path: Content-Disposition: inline In-Reply-To: <504FADC1.4060503-kQCPcA+X3s7YtjvyW6yDsg@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hello, Daniel. On Tue, Sep 11, 2012 at 11:31:45PM +0200, Daniel Wagner wrote: > >Oops, that was wrong. net_prio_subsys_id itself becomes constant. > >Let's please better explain why the RCU trick removal is safe then. > > In the last paragraph in the commit message I tried to document why > it is safe to remove the RCU trick. Not good enough? It isn't clear to me why it was necessary before and why it now becomes unnecessary. It states what the code does and that it's no longer necessary but I'd really like more elaboration. Thanks. -- tejun