From: David Miller <davem@davemloft.net>
To: srivatsa.bhat@linux.vnet.ibm.com
Cc: nhorman@tuxdriver.com, David.Laight@aculab.com,
john.r.fastabend@intel.com, gaofeng@cn.fujitsu.com,
eric.dumazet@gmail.com, mark.d.rustad@intel.com,
lizefan@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH 2/2] netprio_cgroup: Use memcpy instead of the for-loop to copy priomap
Date: Wed, 12 Sep 2012 03:49:01 -0400 (EDT) [thread overview]
Message-ID: <20120912.034901.184817520125489015.davem@davemloft.net> (raw)
In-Reply-To: <20120912060747.11037.42623.stgit@srivatsabhat.in.ibm.com>
From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Date: Wed, 12 Sep 2012 11:37:47 +0530
> + memcpy(new_priomap->priomap, old_priomap->priomap,
> + old_priomap->priomap_len *
> + sizeof(old_priomap->priomap[0]));
This argument indentation is ridiculous. Try:
memcpy(new_priomap->priomap, old_priomap->priomap,
old_priomap->priomap_len *
sizeof(old_priomap->priomap[0]));
Using TABs exclusively for argumentat indentation is not the goal.
Rather, lining the arguments up properly so that they sit at the first
column after the first line's openning parenthesis is what you should
be trying to achieve.
And ignoring whatever stylistic convention we may or may not have, I
find it impossibly hard to believe that the code quoted above looks
good even to you.
next prev parent reply other threads:[~2012-09-12 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 6:07 [v2 PATCH 1/2] netprio_cgroup: Remove update_netdev_tables() since it is unnecessary Srivatsa S. Bhat
2012-09-12 6:07 ` [v2 PATCH 2/2] netprio_cgroup: Use memcpy instead of the for-loop to copy priomap Srivatsa S. Bhat
2012-09-12 7:49 ` David Miller [this message]
2012-09-12 8:24 ` Srivatsa S. Bhat
2012-09-12 10:23 ` Srivatsa S. Bhat
2012-09-12 17:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912.034901.184817520125489015.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=David.Laight@aculab.com \
--cc=eric.dumazet@gmail.com \
--cc=gaofeng@cn.fujitsu.com \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mark.d.rustad@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).