From: David Miller <davem@davemloft.net>
To: keil@b1-systems.de
Cc: netdev@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH] mISDN: Fix wrong usage of flush_work_sync while holding locks
Date: Thu, 13 Sep 2012 14:59:37 -0400 (EDT) [thread overview]
Message-ID: <20120913.145937.235693485700301637.davem@davemloft.net> (raw)
In-Reply-To: <1347546980-15923-1-git-send-email-keil@b1-systems.de>
From: Karsten Keil <keil@b1-systems.de>
Date: Thu, 13 Sep 2012 16:36:20 +0200
> It is a bad idea to hold a spinlock and call flush_work_sync.
> Move the workqueue cleanup outside the spinlock and use cancel_work_sync,
> on closing the channel this seems to be the more correct function.
> Remove the never used and constant return value of mISDN_freebchannel.
>
> Signed-off-by: Karsten Keil <keil@b1-systems.de>
> Cc: <stable@kernel.org>
Applied, thanks.
next prev parent reply other threads:[~2012-09-13 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 14:36 [PATCH] mISDN: Fix wrong usage of flush_work_sync while holding locks Karsten Keil
2012-09-13 18:59 ` David Miller [this message]
2012-09-13 19:06 ` David Miller
2012-09-13 19:50 ` Karsten Keil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913.145937.235693485700301637.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=keil@b1-systems.de \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).