From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net PATCH v2 1/7] bnx2x: Avoid sending multiple statistics
 queries
Date: Thu, 13 Sep 2012 16:17:11 -0400 (EDT)
Message-ID: <20120913.161711.2180618409918407558.davem@davemloft.net>
References: <1347374054-16730-1-git-send-email-yuvalmin@broadcom.com>
	<1347374054-16730-2-git-send-email-yuvalmin@broadcom.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, dmitry@broadcom.com, eilong@broadcom.com
To: yuvalmin@broadcom.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([149.20.54.216]:49029 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752419Ab2IMURN (ORCPT
	<rfc822;netdev@vger.kernel.org>); Thu, 13 Sep 2012 16:17:13 -0400
In-Reply-To: <1347374054-16730-2-git-send-email-yuvalmin@broadcom.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: "Yuval Mintz" <yuvalmin@broadcom.com>
Date: Tue, 11 Sep 2012 17:34:08 +0300

> From: Dmitry Kravkov <dmitry@broadcom.com>
> 
> During traffic when DCB is enabled, it is possible for multiple instances
> of statistics queries to be sent to the chip - this may cause the FW to assert.
> 
> This patch prevents the sending of an additional instance of statistics query
> while the previous query hasn't completed.
> 
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>

This change results in no change in behavior as far as I can tell.

> -	if (bnx2x_storm_stats_update(bp) && (bp->stats_pending++ == 3)) {
> -		BNX2X_ERR("storm stats were not updated for 3 times\n");
> -		bnx2x_panic();
> +	if (bnx2x_storm_stats_update(bp)) {
> +		if (bp->stats_pending++ == 3) {
> +			BNX2X_ERR("storm stats were not updated for 3 times\n");
> +			bnx2x_panic();
> +		}

There is no difference between:

	if (A && B) {
		C;
	}

and:

	if (A) {
		if (B) {
			C;
		}
	}

Yet that's exactly what is happening in this patch.

And such a do-nothing change is certainly not appropriate this late in
the -rc series.

I'm tossing this entire series, please sort this out and submit
the real actual critical bug fixes.