From: "Michael S. Tsirkin" <mst@redhat.com>
To: netdev@vger.kernel.org, Herbert Xu <herbert@gondor.hengli.com.au>
Subject: skb_linearize
Date: Sun, 16 Sep 2012 12:17:47 +0300 [thread overview]
Message-ID: <20120916091747.GA23775@redhat.com> (raw)
I notice that dev_hard_start_xmit might invoke
__skb_linearize e.g. if device does not support NETIF_F_SG.
This in turn onvokes __pskb_pull_tail, and
documentation of __pskb_pull_tail says:
&sk_buff MUST have reference count of 1.
I am guessing 'reference count' means users in this context, right?
IIUC this is because it modifies skb in a way that
isn't safe if anyone else is looking at the skb.
However, I don't see what guarantees that reference
count is 1 when dev_hard_start_xmit invokes
linearize. In particular it calls dev_queue_xmit_nit
which could queue packets on a network tap.
Could someone help me understand please?
Thanks!
--
MST
next reply other threads:[~2012-09-16 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-16 9:17 Michael S. Tsirkin [this message]
2012-09-16 15:07 ` skb_linearize Ben Hutchings
2012-10-31 19:15 ` skb_linearize Michael S. Tsirkin
2012-10-31 21:03 ` skb_linearize Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120916091747.GA23775@redhat.com \
--to=mst@redhat.com \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).