From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] xfrm_user: return error pointer instead of NULL Date: Tue, 18 Sep 2012 16:16:15 -0400 (EDT) Message-ID: <20120918.161615.2073424715014606822.davem@davemloft.net> References: <1347572486-1628-1-git-send-email-minipli@googlemail.com> <20120917071642.GC13023@secunet.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: minipli@googlemail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org To: steffen.klassert@secunet.com Return-path: In-Reply-To: <20120917071642.GC13023@secunet.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Steffen Klassert Date: Mon, 17 Sep 2012 09:16:42 +0200 > On Thu, Sep 13, 2012 at 11:41:26PM +0200, Mathias Krause wrote: >> When dump_one_state() returns an error, e.g. because of a too small >> buffer to dump the whole xfrm state, xfrm_state_netlink() returns NULL >> instead of an error pointer. But its callers expect an error pointer >> and therefore continue to operate on a NULL skbuff. >> >> This could lead to a privilege escalation (execution of user code in >> kernel context) if the attacker has CAP_NET_ADMIN and is able to map >> address 0. > > Or it simply crashes with a NULL pointer dereference. > >> >> Cc: stable@vger.kernel.org >> Signed-off-by: Mathias Krause > > Acked-by: Steffen Klassert Applied, and queued up for -stable. Please do not CC: stable explicitly in your patch submissions, I removed it from the patch. Instead, ask me to queue the patch up for -stable. We handle stable submissed via a patch queue which I maintain at: http://patchwork.ozlabs.org/user/bundle/2566/?state=* so that I can let patches cook in Linus's tree for a length of time of my choosing, rather than having bug fixes automatically propagate the moment it hits Linus's tree. Thanks.