From: Francois Romieu <romieu@fr.zoreil.com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] ucc_geth: Reduce IRQ off in xmit path
Date: Wed, 19 Sep 2012 00:39:38 +0200 [thread overview]
Message-ID: <20120918223938.GA22868@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1347987385-19071-1-git-send-email-Joakim.Tjernlund@transmode.se>
Joakim Tjernlund <Joakim.Tjernlund@transmode.se> :
> Currently ucc_geth_start_xmit wraps IRQ off for the
> whole body just to be safe.
> Reduce the IRQ off period to a minimum.
The driver does not do much work in its irq handler. You may as well
convert it to the usual tg3-ish locking style (i.e. almost no locking).
--
Ueimor
next prev parent reply other threads:[~2012-09-18 22:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 16:56 [PATCH 1/5] ucc_geth: Reduce IRQ off in xmit path Joakim Tjernlund
2012-09-18 16:56 ` [PATCH 2/5] ucc_geth: Word align Ethernet RX data Joakim Tjernlund
2012-10-03 13:17 ` Joakim Tjernlund
2012-09-18 16:56 ` [PATCH 3/5] ucc_geth: Fix two gcc warnings Joakim Tjernlund
2012-10-03 13:17 ` Joakim Tjernlund
2012-09-18 16:56 ` [PATCH 4/5] ucc_geth: Increase RX ring buffer from 32 to 64 Joakim Tjernlund
2012-10-03 13:17 ` Joakim Tjernlund
2012-10-03 19:38 ` David Miller
2012-10-03 20:13 ` Joakim Tjernlund
2012-09-18 16:56 ` [PATCH 5/5] ucc_geth: Add IRQ coalescing Joakim Tjernlund
2012-10-03 13:18 ` Joakim Tjernlund
2012-09-18 22:39 ` Francois Romieu [this message]
2012-09-19 7:36 ` [PATCH 1/5] ucc_geth: Reduce IRQ off in xmit path Joakim Tjernlund
2012-09-19 22:34 ` Francois Romieu
2012-09-20 8:06 ` Joakim Tjernlund
2012-09-20 8:17 ` [PATCH v2] " Joakim Tjernlund
2012-09-20 21:08 ` David Miller
2012-09-21 9:00 ` Joakim Tjernlund
2012-09-21 9:11 ` [PATCH v3] ucc_geth: Lockless xmit Joakim Tjernlund
2012-09-21 12:51 ` Francois Romieu
[not found] ` <OF6B2AFF0B.1C979828-ONC1257A80.00502DCF-C1257A80.00509C7E@LocalDomain>
[not found] ` <OF53C63B27.8D5BE7C3-ONC1257A80.00575156-C1257A80.005766FC@transmode.se>
[not found] ` <20120921173535.GA27934@electric-eye.fr.zoreil.com>
2012-09-23 9:39 ` Joakim Tjernlund
2012-09-24 21:10 ` Francois Romieu
2012-09-25 14:09 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120918223938.GA22868@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox