From: David Miller <davem@davemloft.net>
To: paolo.valente@unimore.it
Cc: shemminger@vyatta.com, jhs@mojatatu.com, fchecconi@gmail.com,
rizzo@iet.unipi.it, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: fix virtual-start-time update in QFQ
Date: Wed, 19 Sep 2012 16:25:06 -0400 (EDT) [thread overview]
Message-ID: <20120919.162506.1493337375457097539.davem@davemloft.net> (raw)
In-Reply-To: <20120915104134.GA29862@paolo-ThinkPad-W520>
From: Paolo Valente <paolo.valente@unimore.it>
Date: Sat, 15 Sep 2012 12:41:35 +0200
> If the old timestamps of a class, say cl, are stale when the class
> becomes active, then QFQ may assign to cl a much higher start time
> than the maximum value allowed. This may happen when QFQ assigns to
> the start time of cl the finish time of a group whose classes are
> characterized by a higher value of the ratio
> max_class_pkt/weight_of_the_class with respect to that of
> cl. Inserting a class with a too high start time into the bucket list
> corrupts the data structure and may eventually lead to crashes.
> This patch limits the maximum start time assigned to a class.
>
> Signed-off-by: Paolo Valente <paolo.valente@unimore.it>
Applied and queued up for -stable, thanks.
Please use "pkt_sched" instead of just plain "sched" in the prefixes
of your subject lines for packet scheduler changes so such changes
can be distinguished from process scheduler changes.
I fixed it up for you this time.
Thanks.
prev parent reply other threads:[~2012-09-19 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-15 10:41 [PATCH] sched: fix virtual-start-time update in QFQ Paolo Valente
2012-09-19 20:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919.162506.1493337375457097539.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fchecconi@gmail.com \
--cc=jhs@mojatatu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paolo.valente@unimore.it \
--cc=rizzo@iet.unipi.it \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).