* [PATCH] fix ZOMBIE state bug in PPPOE driver
[not found] <CANEcBPSEamgOiGqNUSwB+hYCo1k2OTXDA=qsrw0Co8_F7treWw@mail.gmail.com>
@ 2012-09-16 2:30 ` Xiaodong Xu
2012-09-17 3:35 ` Cong Wang
2012-09-19 20:26 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Xiaodong Xu @ 2012-09-16 2:30 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev
Hi All,
I found a bug in kernel PPPOE driver.
When PPPOE is running over a virtual ethernet interface (e.g., a
bonding interface) and the user tries to delete the interface in case
the PPPOE state is ZOMBIE, the kernel will loop infinitely while
unregistering net_device for the reference count is not reset to zero
which should be done by dev_put().
The following patch could fix this issue:
$ git diff
diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index cbf7047..20f31d0 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -570,7 +570,7 @@ static int pppoe_release(struct socket *sock)
po = pppox_sk(sk);
- if (sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND)) {
+ if (sk->sk_state & (PPPOX_CONNECTED | PPPOX_BOUND | PPPOX_ZOMBIE)) {
dev_put(po->pppoe_dev);
po->pppoe_dev = NULL;
}
Thanks.
Regards,
Xiaodong Xu
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fix ZOMBIE state bug in PPPOE driver
2012-09-16 2:30 ` [PATCH] fix ZOMBIE state bug in PPPOE driver Xiaodong Xu
@ 2012-09-17 3:35 ` Cong Wang
2012-09-19 20:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2012-09-17 3:35 UTC (permalink / raw)
To: Xiaodong Xu; +Cc: linux-kernel, netdev
On Sun, Sep 16, 2012 at 10:30 AM, Xiaodong Xu <stid.smth@gmail.com> wrote:
> Hi All,
>
> I found a bug in kernel PPPOE driver.
> When PPPOE is running over a virtual ethernet interface (e.g., a
> bonding interface) and the user tries to delete the interface in case
> the PPPOE state is ZOMBIE, the kernel will loop infinitely while
> unregistering net_device for the reference count is not reset to zero
> which should be done by dev_put().
>
> The following patch could fix this issue:
You missed your Signed-off-by, please read
Documentation/SubmittingPatches and check your patch with
scripts/checkpatch.pl before sending.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix ZOMBIE state bug in PPPOE driver
2012-09-16 2:30 ` [PATCH] fix ZOMBIE state bug in PPPOE driver Xiaodong Xu
2012-09-17 3:35 ` Cong Wang
@ 2012-09-19 20:26 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-09-19 20:26 UTC (permalink / raw)
To: stid.smth; +Cc: linux-kernel, netdev
From: Xiaodong Xu <stid.smth@gmail.com>
Date: Sun, 16 Sep 2012 10:30:53 +0800
> Hi All,
>
> I found a bug in kernel PPPOE driver.
> When PPPOE is running over a virtual ethernet interface (e.g., a
> bonding interface) and the user tries to delete the interface in case
> the PPPOE state is ZOMBIE, the kernel will loop infinitely while
> unregistering net_device for the reference count is not reset to zero
> which should be done by dev_put().
>
> The following patch could fix this issue:
>
> $ git diff
Please read Documentation/SubmittingPatches in the kernel source tree
to learn how to properly submit a patch.
In particular your patch was missing a proper signoff and your Subject
line is incorrectly specified.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-19 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CANEcBPSEamgOiGqNUSwB+hYCo1k2OTXDA=qsrw0Co8_F7treWw@mail.gmail.com>
2012-09-16 2:30 ` [PATCH] fix ZOMBIE state bug in PPPOE driver Xiaodong Xu
2012-09-17 3:35 ` Cong Wang
2012-09-19 20:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).