From: David Miller <davem@davemloft.net>
To: lorenzo@google.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, maze@google.com,
therbert@google.com
Subject: Re: [PATCH net-next] net: only run neigh_forced_gc() from one cpu
Date: Wed, 19 Sep 2012 23:51:02 -0400 (EDT) [thread overview]
Message-ID: <20120919.235102.1659819445753338481.davem@davemloft.net> (raw)
In-Reply-To: <CAKD1Yr11twYakD=-Mn8FiB11-xtyOLb-Q6XWmiE3H63SFRbzUw@mail.gmail.com>
From: Lorenzo Colitti <lorenzo@google.com>
Date: Thu, 20 Sep 2012 12:48:09 +0900
> Sorry to butt in, but just to clarify - are you just saying that the
> description should mention IPv6 explicitly, or is there something else
> wrong with the patch?
>
> If this patch makes IPv6 performance better without affecting IPv4, it's a
> good idea to apply it anyway, right? IPv6 dst entry garbage collection can
> potentially cause serious performance issues on any server with a public
> IPv6 address, and this patch substantially improves the situation.
He's targetting net-next, and I've told him both in previous public
discussions and in recent private communication that the correct fix
is to make ipv6 routes use ref-count-less neighbour handling schemes
like ipv4.
This patch will not be applied as-is, it's not the correct way to fix
this problem.
next prev parent reply other threads:[~2012-09-20 3:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 9:27 [PATCH net-next] net: only run neigh_forced_gc() from one cpu Eric Dumazet
2012-09-19 10:50 ` Neil Horman
2012-09-19 11:07 ` Eric Dumazet
2012-09-19 11:09 ` Eric Dumazet
2012-09-19 12:54 ` Neil Horman
2012-09-19 17:45 ` David Miller
[not found] ` <CAKD1Yr11twYakD=-Mn8FiB11-xtyOLb-Q6XWmiE3H63SFRbzUw@mail.gmail.com>
2012-09-20 3:51 ` David Miller [this message]
2012-09-20 11:22 ` Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919.235102.1659819445753338481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).