From: David Miller <davem@davemloft.net>
To: sony.chacko@qlogic.com
Cc: netdev@vger.kernel.org, Dept_NX_Linux_NIC_Driver@qlogic.com
Subject: Re: [PATCH v1 12/19] qlcnic: update irq management routines
Date: Thu, 20 Sep 2012 18:32:31 -0400 (EDT) [thread overview]
Message-ID: <20120920.183231.24638843071384472.davem@davemloft.net> (raw)
In-Reply-To: <1348098373-20745-13-git-send-email-sony.chacko@qlogic.com>
From: Sony Chacko <sony.chacko@qlogic.com>
Date: Wed, 19 Sep 2012 19:46:06 -0400
> + if (QLCNIC_IS_83XX(adapter) &&
> + (adapter->flags & QLCNIC_MSIX_ENABLED)) {
This is not indented properly. The first character on the second
line should be at the first column after the openning parenthesis
on the first line.
> + for (ring = 0; ring < adapter->max_drv_tx_rings;
> + ring++) {
Same problem here.
> + for (ring = 0; ring < adapter->max_drv_tx_rings;
> + ring++) {
And here as well.
next prev parent reply other threads:[~2012-09-20 22:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 23:45 [PATCH v1 0/19] qlcnic: patches for new adapter - Qlogic 83XX CNA Sony Chacko
2012-09-19 23:45 ` [PATCH v1 01/19] qlcnic: remove 82xx specific register dump utility Sony Chacko
2012-09-19 23:45 ` [PATCH v1 02/19] qlcnic: move HW specific data to seperate structure Sony Chacko
2012-09-19 23:45 ` [PATCH v1 03/19] qlcnic: create seperate file for data path routines Sony Chacko
2012-09-19 23:45 ` [PATCH v1 04/19] qlcnic: change IO and PCI register acccess routines Sony Chacko
2012-09-19 23:45 ` [PATCH v1 05/19] qlcnic: change driver hardware interface mechanism Sony Chacko
2012-09-20 0:57 ` David Miller
2012-09-19 23:46 ` [PATCH v1 06/19] qlcnic: driver resource allocation Sony Chacko
2012-09-19 23:46 ` [PATCH v1 07/19] qlcnic: get board name API Sony Chacko
2012-09-19 23:46 ` [PATCH v1 08/19] qlcnic: update NIC partition interface routines Sony Chacko
2012-09-19 23:46 ` [PATCH v1 09/19] qlcnic: cleanup unused register interfaces Sony Chacko
2012-09-19 23:46 ` [PATCH v1 10/19] qlcnic: rename module params with module_param_named Sony Chacko
2012-09-19 23:46 ` [PATCH v1 11/19] qlcnic: sysfs interface routine updates Sony Chacko
2012-09-20 22:31 ` David Miller
2012-09-19 23:46 ` [PATCH v1 12/19] qlcnic: update irq management routines Sony Chacko
2012-09-20 22:32 ` David Miller [this message]
2012-09-19 23:46 ` [PATCH v1 13/19] qlcnic: 83xx hardware access and data path routines Sony Chacko
2012-09-20 22:45 ` David Miller
2012-09-19 23:46 ` [PATCH v1 14/19] qlcnic: 83xx adpater flash interface routines Sony Chacko
2012-09-19 23:46 ` [PATCH v1 15/19] qlcnic: 83xx CNA inter driver communication mechanism Sony Chacko
2012-09-19 23:46 ` [PATCH v1 16/19] qlcnic: enable 83xx virtual NIC mode Sony Chacko
2012-09-19 23:46 ` [PATCH v1 17/19] qlcnic: common register dump utility Sony Chacko
2012-09-19 23:46 ` [PATCH v1 18/19] qlcnic: 83xx adpater ethtool Sony Chacko
2012-09-19 23:46 ` [PATCH v1 19/19] qlcnic: update driver version - 5.1.30 Sony Chacko
2012-09-20 22:47 ` [PATCH v1 0/19] qlcnic: patches for new adapter - Qlogic 83XX CNA David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-09-19 19:29 Sony Chacko
2012-09-19 19:29 ` [PATCH v1 12/19] qlcnic: update irq management routines Sony Chacko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920.183231.24638843071384472.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept_NX_Linux_NIC_Driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).