From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: [PATCH] openvswitch: using kfree_rcu() to simplify the code Date: Thu, 20 Sep 2012 10:47:36 -0700 Message-ID: <20120920174736.GJ2449@linux.vnet.ibm.com> References: Reply-To: paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: Wei Yongjun Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org On Mon, Aug 27, 2012 at 12:20:45PM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Wei Yongjun Reviewed-by: Paul E. McKenney > --- > net/openvswitch/flow.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c > index b7f38b1..c7bf2f2 100644 > --- a/net/openvswitch/flow.c > +++ b/net/openvswitch/flow.c > @@ -427,19 +427,11 @@ void ovs_flow_deferred_free(struct sw_flow *flow) > call_rcu(&flow->rcu, rcu_free_flow_callback); > } > > -/* RCU callback used by ovs_flow_deferred_free_acts. */ > -static void rcu_free_acts_callback(struct rcu_head *rcu) > -{ > - struct sw_flow_actions *sf_acts = container_of(rcu, > - struct sw_flow_actions, rcu); > - kfree(sf_acts); > -} > - > /* Schedules 'sf_acts' to be freed after the next RCU grace period. > * The caller must hold rcu_read_lock for this to be sensible. */ > void ovs_flow_deferred_free_acts(struct sw_flow_actions *sf_acts) > { > - call_rcu(&sf_acts->rcu, rcu_free_acts_callback); > + kfree_rcu(sf_acts, rcu); > } > > static int parse_vlan(struct sk_buff *skb, struct sw_flow_key *key) > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >