From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] stmmac: fix return value check in stmmac_open_ext_timer() Date: Fri, 21 Sep 2012 13:47:36 -0400 (EDT) Message-ID: <20120921.134736.1491471500558263203.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: peppe.cavallaro@st.com, yongjun_wei@trendmicro.com.cn, netdev@vger.kernel.org To: weiyj.lk@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:50907 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932345Ab2IURrl (ORCPT ); Fri, 21 Sep 2012 13:47:41 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Wei Yongjun Date: Fri, 21 Sep 2012 15:06:10 +0800 > From: Wei Yongjun > > In case of error, the function clk_get() returns ERR_PTR() > and never returns NULL pointer. The NULL test in the error > handling should be replaced with IS_ERR(). > > dpatch engine is used to auto generated this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Applied.